[wborn]

Description

• Preserve last-will connection lookups during disconnect cleanup.
• Prevent stale disconnect callbacks from removing newer connections.
• Add deterministic regression tests for disconnect races.
• Split MqttBrokerTest into ten independent features with shared setup, cleanup and assertion helpers.
• Wait for subscription acknowledgements and broker cleanup, and use timed queue polls to check for unwanted events.

Checklist

• 1. Acceptance criteria of the linked issue(s) are met
• 2. Tests are written and all tests pass
• 3. Changes are manually tested by you and the reviewer
• 4. Documentation is written or updated

[wborn]

With the changes in this PR it seems to have been stabilized as it didn't fail any time after running the integration tests 50 times, see: https://github.com/openremote/core/actions/runs/40504589812

Only the GatewayTest failed for which I've created #3507.

[richturner]

I like the approach here but now using more tests within the spec and calling startContainer between each in setup will impact the time it takes to run the specification.

It would be nice to try and use setupSpec and ensure each test cleans up any residual state, this would likely dramatically improve the execution time.

[wborn]

I already thought it was structured like one big test to reduce test time. 😉
The separation into different tests was done to make it more readable and easier to see what logic is broken.
Using setupSpec/cleanup seems to work and reduces the total execution time by 10s (23.3% reduction).

[sonarqubecloud]

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud