Drop the onboarding

CHANGELOG.md

@@ -41,12 +41,16 @@ once the version tag exists.
   `.xlm` can be picked in the document browser instead of being greyed out.
   odrcore rendered them already; the app claimed no type that reached them.
 - The app is translated again. Every language but English was showing English
-  for the onboarding buttons, the privacy screen and the banner, and Danish,
-  Catalan, Turkish and Czech showed it for most of the rest.
-- The Chinese introduction named a different app.
+  for the privacy screen and the banner, and Danish, Catalan, Turkish and Czech
+  showed it for most of the rest.
 - Tapping a document sets the cursor, so an edit can be typed. The keyboard
   never came up before.
 
+### Removed
+
+- The three onboarding pages on first launch. The app opens on the document
+  browser instead.
+
 ## [1.40]
 
 ### Changed

OpenDocumentReader/Constants.swift

@@ -9,10 +9,6 @@
 import Foundation
 
 enum Constants {
-    static let onboardingImages = ["onboard1", "onboard2", "onboard3"]
-
-    static let key_was_intro_watched = "wasIntroWatched"
-
     /// Which of the house ad's rotations comes next.
     static let key_house_ad_index = "houseAdIndex"
 

OpenDocumentReader/DocumentBrowserViewController.swift

@@ -9,8 +9,6 @@ import UIKit
 
 class DocumentBrowserViewController: UIDocumentBrowserViewController, UIDocumentBrowserViewControllerDelegate {
 
-    let pageViewController = "pageViewController"
-
     override func viewDidLoad() {
         super.viewDidLoad()
         delegate = self
@@ -23,19 +21,7 @@ class DocumentBrowserViewController: UIDocumentBrowserViewController, UIDocument
         super.viewDidAppear(animated)
 
         StoreReviewHelper.checkAndAskForReview()
-
-        // ahead of the intro guard below, which most launches return at
         refreshPrivacyButton()
-
-        let userDefaults = UserDefaults.standard
-        let wasIntroWatched = userDefaults.bool(forKey: Constants.key_was_intro_watched)
-
-        guard !wasIntroWatched else { return }
-
-        if let pageVC = storyboard?.instantiateViewController(withIdentifier: pageViewController) as? PageViewController
-        {
-            present(pageVC, animated: true, completion: nil)
-        }
     }
 
     // MARK: - Privacy

OpenDocumentReader/Main.storyboard

@@ -122,104 +122,6 @@
             </objects>
             <point key="canvasLocation" x="1028.985507246377" y="652.90178571428567"/>
         </scene>
-        <!--Page View Controller-->
-        <scene sceneID="Eae-fc-jpm">
-            <objects>
-                <pageViewController storyboardIdentifier="pageViewController" autoresizesArchivedViewToFullSize="NO" transitionStyle="scroll" navigationOrientation="horizontal" spineLocation="none" id="wgM-CS-OHl" customClass="PageViewController" customModule="OpenDocumentReader" customModuleProvider="target" sceneMemberID="viewController"/>
-                <placeholder placeholderIdentifier="IBFirstResponder" id="wq2-xw-nG5" userLabel="First Responder" customClass="UIResponder" sceneMemberID="firstResponder"/>
-            </objects>
-            <point key="canvasLocation" x="25" y="1409"/>
-        </scene>
-        <!--Content View Controller-->
-        <scene sceneID="GKG-xC-aGa">
-            <objects>
-                <viewController storyboardIdentifier="contentViewController" id="j3v-2A-vTf" customClass="ContentViewController" customModule="OpenDocumentReader" customModuleProvider="target" sceneMemberID="viewController">
-                    <view key="view" contentMode="scaleToFill" id="rdl-av-fpl">
-                        <rect key="frame" x="0.0" y="0.0" width="414" height="896"/>
-                        <autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
-                        <subviews>
-                            <stackView opaque="NO" contentMode="scaleToFill" distribution="fillProportionally" spacing="20" translatesAutoresizingMaskIntoConstraints="NO" id="nfe-JJ-89b">
-                                <rect key="frame" x="15" y="813" width="384" height="39"/>
-                                <subviews>
-                                    <button opaque="NO" contentMode="scaleToFill" contentHorizontalAlignment="center" contentVerticalAlignment="center" buttonType="system" lineBreakMode="middleTruncation" translatesAutoresizingMaskIntoConstraints="NO" id="uLV-WY-zIj">
-                                        <rect key="frame" x="0.0" y="0.0" width="65" height="39"/>
-                                        <fontDescription key="fontDescription" type="system" pointSize="22"/>
-                                        <state key="normal" title="Skip">
-                                            <color key="titleColor" white="0.66666666666666663" alpha="1" colorSpace="custom" customColorSpace="genericGamma22GrayColorSpace"/>
-                                        </state>
-                                        <connections>
-                                            <action selector="pageButtonPressed:" destination="j3v-2A-vTf" eventType="touchUpInside" id="ElH-au-ZCA"/>
-                                            <action selector="skipButtonPressed:" destination="j3v-2A-vTf" eventType="touchUpInside" id="fCO-dq-vjw"/>
-                                        </connections>
-                                    </button>
-                                    <pageControl opaque="NO" contentMode="scaleToFill" contentHorizontalAlignment="center" contentVerticalAlignment="center" numberOfPages="3" translatesAutoresizingMaskIntoConstraints="NO" id="Eq9-2L-Y0h">
-                                        <rect key="frame" x="84.999999999999986" y="0.0" width="187.66666666666663" height="39"/>
-                                        <color key="pageIndicatorTintColor" white="0.66666666666666663" alpha="1" colorSpace="custom" customColorSpace="genericGamma22GrayColorSpace"/>
-                                        <color key="currentPageIndicatorTintColor" white="1" alpha="1" colorSpace="custom" customColorSpace="genericGamma22GrayColorSpace"/>
-                                    </pageControl>
-                                    <button opaque="NO" contentMode="scaleToFill" contentHorizontalAlignment="center" contentVerticalAlignment="center" buttonType="system" lineBreakMode="middleTruncation" translatesAutoresizingMaskIntoConstraints="NO" id="BJ9-WO-km9">
-                                        <rect key="frame" x="292.66666666666669" y="0.0" width="91.333333333333314" height="39"/>
-                                        <fontDescription key="fontDescription" type="system" pointSize="22"/>
-                                        <state key="normal" title="Next">
-                                            <color key="titleColor" white="1" alpha="1" colorSpace="custom" customColorSpace="genericGamma22GrayColorSpace"/>
-                                        </state>
-                                        <connections>
-                                            <action selector="pageButtonPressed:" destination="j3v-2A-vTf" eventType="touchUpInside" id="O9h-7h-qi8"/>
-                                        </connections>
-                                    </button>
-                                </subviews>
-                            </stackView>
-                            <stackView opaque="NO" contentMode="scaleToFill" axis="vertical" distribution="fillEqually" alignment="center" translatesAutoresizingMaskIntoConstraints="NO" id="RSj-Lv-N7s">
-                                <rect key="frame" x="15" y="44" width="384" height="778"/>
-                                <subviews>
-                                    <imageView clipsSubviews="YES" userInteractionEnabled="NO" contentMode="scaleAspectFit" horizontalHuggingPriority="251" verticalHuggingPriority="251" translatesAutoresizingMaskIntoConstraints="NO" id="Eqj-3O-0hy">
-                                        <rect key="frame" x="47" y="0.0" width="290" height="389"/>
-                                    </imageView>
-                                    <stackView opaque="NO" contentMode="scaleToFill" axis="vertical" distribution="fillProportionally" translatesAutoresizingMaskIntoConstraints="NO" id="JPv-Mc-T5Q">
-                                        <rect key="frame" x="140" y="389" width="104.33333333333331" height="389"/>
-                                        <subviews>
-                                            <label opaque="NO" userInteractionEnabled="NO" contentMode="left" horizontalHuggingPriority="251" verticalHuggingPriority="251" text="Header " textAlignment="center" lineBreakMode="tailTruncation" numberOfLines="2" baselineAdjustment="alignBaselines" minimumScaleFactor="0.5" translatesAutoresizingMaskIntoConstraints="NO" id="dnY-xL-bHh">
-                                                <rect key="frame" x="0.0" y="0.0" width="104.33333333333333" height="224.66666666666666"/>
-                                                <fontDescription key="fontDescription" type="system" pointSize="30"/>
-                                                <nil key="textColor"/>
-                                                <nil key="highlightedColor"/>
-                                            </label>
-                                            <label opaque="NO" userInteractionEnabled="NO" contentMode="left" horizontalHuggingPriority="251" verticalHuggingPriority="252" verticalCompressionResistancePriority="751" text="Subheader" textAlignment="center" lineBreakMode="tailTruncation" numberOfLines="8" baselineAdjustment="alignBaselines" minimumScaleFactor="0.5" translatesAutoresizingMaskIntoConstraints="NO" id="jic-3b-2I7">
-                                                <rect key="frame" x="0.0" y="224.66666666666663" width="104.33333333333333" height="164.33333333333337"/>
-                                                <fontDescription key="fontDescription" type="system" pointSize="22"/>
-                                                <color key="textColor" white="0.66666666666666663" alpha="1" colorSpace="custom" customColorSpace="genericGamma22GrayColorSpace"/>
-                                                <nil key="highlightedColor"/>
-                                            </label>
-                                        </subviews>
-                                    </stackView>
-                                </subviews>
-                            </stackView>
-                        </subviews>
-                        <viewLayoutGuide key="safeArea" id="19r-M9-NT1"/>
-                        <color key="backgroundColor" systemColor="systemBackgroundColor"/>
-                        <constraints>
-                            <constraint firstItem="19r-M9-NT1" firstAttribute="bottom" secondItem="nfe-JJ-89b" secondAttribute="bottom" constant="10" id="3n6-rA-Oua"/>
-                            <constraint firstItem="nfe-JJ-89b" firstAttribute="centerX" secondItem="19r-M9-NT1" secondAttribute="centerX" id="8q6-eN-xbY"/>
-                            <constraint firstItem="19r-M9-NT1" firstAttribute="trailing" secondItem="nfe-JJ-89b" secondAttribute="trailing" constant="15" id="fxw-r8-WgU"/>
-                            <constraint firstItem="19r-M9-NT1" firstAttribute="trailing" secondItem="RSj-Lv-N7s" secondAttribute="trailing" constant="15" id="gM8-DB-J2A"/>
-                            <constraint firstItem="nfe-JJ-89b" firstAttribute="leading" secondItem="19r-M9-NT1" secondAttribute="leading" constant="15" id="pdt-tQ-3ax"/>
-                            <constraint firstItem="RSj-Lv-N7s" firstAttribute="top" secondItem="19r-M9-NT1" secondAttribute="top" id="qn1-PB-GcS"/>
-                            <constraint firstItem="RSj-Lv-N7s" firstAttribute="leading" secondItem="19r-M9-NT1" secondAttribute="leading" constant="15" id="srH-sh-jXs"/>
-                            <constraint firstItem="RSj-Lv-N7s" firstAttribute="bottom" secondItem="nfe-JJ-89b" secondAttribute="bottom" constant="-30" id="vAp-4c-dIi"/>
-                        </constraints>
-                    </view>
-                    <connections>
-                        <outlet property="headerLabel" destination="dnY-xL-bHh" id="GxF-Ni-SSZ"/>
-                        <outlet property="imageView" destination="Eqj-3O-0hy" id="vpx-IU-yHm"/>
-                        <outlet property="pageButton" destination="BJ9-WO-km9" id="Cwh-4l-b8f"/>
-                        <outlet property="pageControl" destination="Eq9-2L-Y0h" id="xFr-gd-g2O"/>
-                        <outlet property="subHeaderLabel" destination="jic-3b-2I7" id="hML-1t-P9n"/>
-                    </connections>
-                </viewController>
-                <placeholder placeholderIdentifier="IBFirstResponder" id="vek-qX-cs8" userLabel="First Responder" customClass="UIResponder" sceneMemberID="firstResponder"/>
-            </objects>
-            <point key="canvasLocation" x="1700.0000000000002" y="1589.7321428571429"/>
-        </scene>
     </scenes>
     <resources>
         <image name="chevron.backward" catalog="system" width="76" height="128"/>