Drop the onboarding - #166
Merged
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1c60470fb9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Three pages between somebody and their documents, shown once and never again. The app opens on the document browser instead, which is what it is for. Out with them go the two view controllers, their storyboard scenes, the three pictures and fifteen strings in sixteen languages. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E6tn8P25cBDmrA67zrhfwN
andiwand
force-pushed
the
drop-the-onboarding
branch
from
August 17, 2026 10:11
1c60470 to
a627c84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three pages between somebody and their documents, shown once and never again, and then dead weight in the bundle forever.
The app opens on the document browser now, which is what it is for. A reader is not a product that needs explaining: the first thing you want is your files.
What goes
PageViewControllerandContentViewController, and their two storyboard scenesonboardimage sets — 2.8 MB of the bundleLocalizable.stringsentries in each of sixteen languagesConstants.key_was_intro_watched, and theUserDefaultsread that gated the whole thing on every launchrefreshPrivacyButton()used to be called before the intro guard, with a comment explaining that most launches returned at that guard. There is no guard now, so the comment goes and the call stays where it is.Checked
key_was_intro_watched,PageViewController,ContentViewControlleroronboardproject.pbxprojchangeSplit out of #164, which is stacked on this: the document browser makes a better first screenshot than three pages of introduction, so the screenshot work assumes this is gone.
🤖 Generated with Claude Code