Skip to content

Drop the onboarding - #166

Merged
andiwand merged 1 commit into
mainfrom
drop-the-onboarding
Aug 17, 2026
Merged

Drop the onboarding#166
andiwand merged 1 commit into
mainfrom
drop-the-onboarding

Conversation

@andiwand

Copy link
Copy Markdown
Member

Three pages between somebody and their documents, shown once and never again, and then dead weight in the bundle forever.

The app opens on the document browser now, which is what it is for. A reader is not a product that needs explaining: the first thing you want is your files.

What goes

  • PageViewController and ContentViewController, and their two storyboard scenes
  • the three onboard image sets — 2.8 MB of the bundle
  • fifteen Localizable.strings entries in each of sixteen languages
  • Constants.key_was_intro_watched, and the UserDefaults read that gated the whole thing on every launch

refreshPrivacyButton() used to be called before the intro guard, with a comment explaining that most launches returned at that guard. There is no guard now, so the comment goes and the call stays where it is.

Checked

  • builds clean for both schemes
  • nothing anywhere still names key_was_intro_watched, PageViewController, ContentViewController or onboard
  • the project uses synchronized file groups, so removing the sources needed no project.pbxproj change

Split out of #164, which is stacked on this: the document browser makes a better first screenshot than three pages of introduction, so the screenshot work assumes this is gone.

🤖 Generated with Claude Code

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1c60470fb9

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread CHANGELOG.md
Three pages between somebody and their documents, shown once and never
again. The app opens on the document browser instead, which is what it
is for.

Out with them go the two view controllers, their storyboard scenes, the
three pictures and fifteen strings in sixteen languages.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01E6tn8P25cBDmrA67zrhfwN
@andiwand
andiwand force-pushed the drop-the-onboarding branch from 1c60470 to a627c84 Compare August 17, 2026 10:11
@andiwand
andiwand merged commit 39869fc into main Aug 17, 2026
4 checks passed
@andiwand
andiwand deleted the drop-the-onboarding branch August 17, 2026 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant