Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions sdk/typescript/src/api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2693,12 +2693,6 @@ function reconnectDetails(message: string): ScanReconnectDetails | undefined {
}

// A failed turn must fail the scan whatever its error payload looks like.
//
// Only `error.message` is reused, because that is the single shape the previous
// code already surfaced. No other shape is forwarded or stringified: this message
// reaches `fail-scan --message` and is stored unchanged in `scans.failure_message`,
// so widening what is copied out of the payload would add a new
// credential-disclosure path to persistent scan history.
function turnFailureMessage(error: unknown): string {
if (isRecord(error) && typeof error["message"] === "string") {
const message = error["message"].trim();
Expand Down
1 change: 0 additions & 1 deletion sdk/typescript/src/version.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ const PACKAGE_VERSIONS = packageVersions(
new URL("../package.json", import.meta.url),
);

/** npm-compatible successor to the Python package version 0.1.0b3. */
export const VERSION = PACKAGE_VERSIONS.package;
export const CODEX_SDK_VERSION = PACKAGE_VERSIONS.sdk;
export const CODEX_EXECUTABLE_VERSION = PACKAGE_VERSIONS.executable;
Expand Down
2 changes: 0 additions & 2 deletions sdk/typescript/tests-ts/api-events.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -796,8 +796,6 @@ describe("one-shot scan events", () => {
message: "retry budget exhausted",
});

// A bare string is deliberately NOT reused: it was never surfaced before, and
// this message is stored by fail-scan without redaction.
await expect(
runEvents(
await copyCompletedScan(await temporaryDirectory()),
Expand Down
2 changes: 1 addition & 1 deletion sdk/typescript/tests-ts/cli-authentication.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import {
dependencies as cliDependencies,
fakePreflight,
fakeResult,
} from "./support/cli.js";
} from "./cli-fixtures.js";

let stateDirectory: string;

Expand Down
2 changes: 1 addition & 1 deletion sdk/typescript/tests-ts/cli-launcher.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { join } from "node:path";
import { pathToFileURL } from "node:url";
import { describe, expect, test } from "bun:test";
import { VERSION } from "../src/index.js";
import { SYNTHETIC_CREDENTIALS } from "./support/cli.js";
import { SYNTHETIC_CREDENTIALS } from "./cli-fixtures.js";

const packageRoot = join(import.meta.dir, "..");

Expand Down
2 changes: 1 addition & 1 deletion sdk/typescript/tests-ts/cli-signals.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {
dependencies,
fakePreflight,
fakeResult,
} from "./support/cli.js";
} from "./cli-fixtures.js";

describe("CLI signals", () => {
test("maps Ctrl-C and SIGTERM to conventional exits and preserves partial output", async () => {
Expand Down
2 changes: 1 addition & 1 deletion sdk/typescript/tests-ts/cli-skills.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {
runCodexSkillCommand,
skillCommandFailure,
} from "../src/cli.js";
import { capture, dependencies } from "./support/cli.js";
import { capture, dependencies } from "./cli-fixtures.js";

describe("CLI skill commands", () => {
test("runs validation and patch skills with file and literal inputs", async () => {
Expand Down
2 changes: 1 addition & 1 deletion sdk/typescript/tests-ts/cli-workbench.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {
dependencies,
fakeResult,
SYNTHETIC_CREDENTIALS,
} from "./support/cli.js";
} from "./cli-fixtures.js";

describe("CLI workbench", () => {
test("lists and summarizes open findings for the current repository", async () => {
Expand Down
25 changes: 7 additions & 18 deletions sdk/typescript/tests-ts/release-automation.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1418,6 +1418,13 @@ describe("idempotent GitHub release verification", () => {
});

describe("GitHub release workflow safeguards", () => {
const checkedOutVersion = releaseVersion(
JSON.parse(
readFileSync(new URL("../package.json", import.meta.url), "utf8"),
) as ReleaseMetadata,
);
const checkedOutTag = `npm-v${checkedOutVersion}`;

test("requires a real tag for protected npm publication", () => {
expect(protectedReleaseWorkflow).toContain("release-tag");
expect(protectedReleaseWorkflow).toContain('"$GITHUB_REF_TYPE"');
Expand Down Expand Up @@ -1913,12 +1920,6 @@ describe("GitHub release workflow safeguards", () => {
protectedReleaseWorkflow,
"Revalidate protected release tag",
);
const checkedOutVersion = releaseVersion(
JSON.parse(
readFileSync(new URL("../package.json", import.meta.url), "utf8"),
) as ReleaseMetadata,
);
const checkedOutTag = `npm-v${checkedOutVersion}`;
const mock = [
"gh() {",
' if [[ "$1" != "api" ]]; then return 64; fi',
Expand Down Expand Up @@ -1969,12 +1970,6 @@ describe("GitHub release workflow safeguards", () => {
protectedReleaseWorkflow,
"Validate release tag",
);
const checkedOutVersion = releaseVersion(
JSON.parse(
readFileSync(new URL("../package.json", import.meta.url), "utf8"),
) as ReleaseMetadata,
);
const checkedOutTag = `npm-v${checkedOutVersion}`;
const mocks = [
"git() { return 0; }",
"sfw() { printf '%s\\n' '[\"0.1.1\",\"999999999999999999999999.0.0\"]'; }",
Expand Down Expand Up @@ -2004,12 +1999,6 @@ describe("GitHub release workflow safeguards", () => {
protectedReleaseWorkflow,
"Validate release tag",
);
const checkedOutVersion = releaseVersion(
JSON.parse(
readFileSync(new URL("../package.json", import.meta.url), "utf8"),
) as ReleaseMetadata,
);
const checkedOutTag = `npm-v${checkedOutVersion}`;
const mocks = [
"git() { return 0; }",
`sfw() { printf '%s\\n' '["0.1.0","${checkedOutVersion}"]'; }`,
Expand Down
1 change: 0 additions & 1 deletion sdk/typescript/tests-ts/support/cli.ts

This file was deleted.

Loading