Skip to content

chore: remove stale comments and redundant test indirection - #402

Merged
mldangelo-oai merged 1 commit into
mainfrom
mdangelo/codex/remove-stale-test-indirection
Aug 14, 2026
Merged

chore: remove stale comments and redundant test indirection#402
mldangelo-oai merged 1 commit into
mainfrom
mdangelo/codex/remove-stale-test-indirection

Conversation

@mldangelo-oai

Copy link
Copy Markdown
Collaborator

Summary

Remove obsolete test indirection, duplicated release-test setup, and comments that no longer describe current behavior.

Changes

  • Import shared CLI fixtures directly and delete the one-line fixture re-export.
  • Load the checked-out package version once for related release workflow tests.
  • Remove stale failure-redaction and historical-version comments while preserving the actual redaction and scan-failure behavior.

Testing

  • bun test tests-ts/cli-signals.test.ts tests-ts/cli-authentication.test.ts tests-ts/cli-launcher.test.ts tests-ts/cli-workbench.test.ts tests-ts/cli-skills.test.ts tests-ts/api-events.test.ts tests-ts/release-automation.test.ts --timeout 30000 — passed.
  • pnpm run types — passed.
  • prettier --check for every changed TypeScript file — passed.
  • git diff --check — passed.

Risk and rollout

CLI fixtures retain the same implementation and exports; their consumers import the original module directly. Release scenarios and assertions are unchanged. Production changes remove comments only, including outdated claims about persisted failure-message redaction.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: 5aebe70cb0

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: 5aebe70cb0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@zcrab-oai zcrab-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Simplifies test fixtures and stale comments without changing production behavior or credential coverage.

@mldangelo-oai
mldangelo-oai merged commit e3dac7c into main Aug 14, 2026
34 checks passed
@mldangelo-oai
mldangelo-oai deleted the mdangelo/codex/remove-stale-test-indirection branch August 14, 2026 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants