chore: remove stale comments and redundant test indirection - #402
Conversation
|
@codex review |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
zcrab-oai
left a comment
There was a problem hiding this comment.
Looks good. Simplifies test fixtures and stale comments without changing production behavior or credential coverage.
Summary
Remove obsolete test indirection, duplicated release-test setup, and comments that no longer describe current behavior.
Changes
Testing
bun test tests-ts/cli-signals.test.ts tests-ts/cli-authentication.test.ts tests-ts/cli-launcher.test.ts tests-ts/cli-workbench.test.ts tests-ts/cli-skills.test.ts tests-ts/api-events.test.ts tests-ts/release-automation.test.ts --timeout 30000— passed.pnpm run types— passed.prettier --checkfor every changed TypeScript file — passed.git diff --check— passed.Risk and rollout
CLI fixtures retain the same implementation and exports; their consumers import the original module directly. Release scenarios and assertions are unchanged. Production changes remove comments only, including outdated claims about persisted failure-message redaction.
Public disclosure review