Skip to content

refactor(workbench): share safe source path validation #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mldangelo-oai merged 1 commit into from
Aug 14, 2026
+1 −15
Merged

refactor(workbench): share safe source path validation #396

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 1 addition & 15 deletions sdk/typescript/_bundled_plugin/scripts/workbench_db.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
from workbench_schema import (
sql_statements as sql_statements,
)
from workbench_source_excerpt import finding_source_excerpt
from workbench_source_excerpt import finding_source_excerpt, safe_source_path
from workbench_target import (
clean_worktree_content_digest,
copy_directory_excluding,
Expand Down Expand Up @@ -3462,20 +3462,6 @@ def patch_artifact_preview(
}


def safe_source_path(target: Path, relative_path: str) -> Path | None:
if "\\" in relative_path:
return None
parsed = PurePosixPath(relative_path)
if parsed.is_absolute() or ".." in parsed.parts:
return None
try:
path = (target / parsed.as_posix()).resolve()
path.relative_to(target)
except (OSError, RuntimeError, ValueError):
return None
return path


def available_artifact_path(scan_dir: Path, candidate: Path) -> Path | None:
try:
resolved_scan_dir = require_canonical_scan_directory(scan_dir)
Expand Down
Loading