Skip to content

refactor(workbench): share safe source path validation - #396

Open
mldangelo-oai wants to merge 1 commit into
mainfrom
mdangelo/codex/share-safe-source-path
Open

refactor(workbench): share safe source path validation#396
mldangelo-oai wants to merge 1 commit into
mainfrom
mdangelo/codex/share-safe-source-path

Conversation

@mldangelo-oai

Copy link
Copy Markdown
Collaborator

Summary

Use one implementation for validating finding source paths.

Changes

  • Import the existing source-excerpt path validator into the workbench database module.
  • Delete the identical duplicate implementation while preserving both modules' existing helper names.

Testing

  • bun test tests-ts/plugin-report-limits.test.ts tests-ts/scan-recovery.test.ts --timeout 30000 — passed.
  • python3 -I -B import and path-boundary smoke test — confirmed both modules share the same helper, safe paths remain accepted, and traversal/backslash paths remain rejected.
  • pnpm run types — passed.
  • git diff --check — passed.

Risk and rollout

The shared helper is byte-for-byte equivalent to the removed implementation. Existing repository containment, path traversal, and source-excerpt protections remain unchanged.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: 42cbd91277

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: 42cbd91277

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@zcrab-oai zcrab-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Reuses the identical safe source-path validator without weakening traversal, symlink, or Windows path protections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants