Skip to content

refactor(runtime): remove unused plugin projection path #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mldangelo-oai merged 1 commit into from
Aug 14, 2026
Merged

refactor(runtime): remove unused plugin projection path #395

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 1 addition & 64 deletions sdk/typescript/src/runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1934,20 +1934,7 @@ export async function createMarketplace(
const root = await realpath(pluginRoot);
const marketplace = join(codexHome, "sdk-marketplace");
const pluginDestination = join(marketplace, "plugins", PLUGIN_NAME);
const projectionContract = join(
root,
".internal",
"external-promotion",
"external-projection-contract.json",
);
if (
root === (await bundledPluginRoot()) &&
(await isRegularFile(projectionContract))
) {
await copyExternalPayload(root, pluginDestination);
} else {
await copyPluginTree(root, pluginDestination, signal);
}
await copyPluginTree(root, pluginDestination, signal);
throwIfSignalAborted(signal);
const manifest = {
name: MARKETPLACE_NAME,
Expand Down Expand Up @@ -2386,56 +2373,6 @@ async function readExactly(
return buffer;
}

async function copyExternalPayload(
source: string,
destination: string,
): Promise<void> {
const contractPath = join(
source,
".internal",
"external-promotion",
"external-projection-contract.json",
);
let contract: unknown;
try {
contract = JSON.parse(await readFile(contractPath, "utf8"));
} catch (error) {
throw new PluginBootstrapError(
`Invalid plugin projection contract: ${contractPath}`,
{
cause: error,
},
);
}
const shippedExact = isRecord(contract)
? contract["shippedExact"]
: undefined;
if (
!Array.isArray(shippedExact) ||
!shippedExact.every((value) => typeof value === "string")
) {
throw new PluginBootstrapError(
"Plugin projection contract must contain shippedExact paths.",
);
}
const paths = [".codex-plugin/plugin.json", ...shippedExact].filter(
(value) => !value.startsWith("sdk/"),
);
for (const path of paths) {
const normalized = safeArchivePath(path);
const sourcePath = join(source, ...normalized.split("/"));
const destinationPath = join(destination, ...normalized.split("/"));
const metadata = await lstat(sourcePath).catch(() => null);
if (metadata === null || !metadata.isFile() || metadata.isSymbolicLink()) {
throw new PluginBootstrapError(
`Bundled plugin file is missing or unsafe: ${sourcePath}`,
);
}
await mkdir(dirname(destinationPath), { recursive: true, mode: 0o700 });
await copyFile(sourcePath, destinationPath, constants.COPYFILE_EXCL);
}
}

function safeArchivePath(value: string): string {
const parts = value.split("/");
const normalized = parts
Expand Down
Loading