Skip to content

refactor(runtime): remove unused plugin projection path - #395

Merged
mldangelo-oai merged 1 commit into
mainfrom
mdangelo/codex/remove-dead-plugin-projection
Aug 14, 2026
Merged

refactor(runtime): remove unused plugin projection path#395
mldangelo-oai merged 1 commit into
mainfrom
mdangelo/codex/remove-dead-plugin-projection

Conversation

@mldangelo-oai

Copy link
Copy Markdown
Collaborator

Summary

Remove a bundled-plugin projection path that cannot run in the published package.

Changes

  • Stage validated plugins through the existing safe plugin-tree copier.
  • Delete the unused projection-contract parser and alternate copy implementation.

Testing

  • bun test tests-ts/runtime.test.ts --timeout 30000 — 118 passed; 7 Windows-only tests skipped on macOS.
  • pnpm run types — passed.
  • prettier --check src/runtime.ts — passed.
  • git diff --check — passed.

Risk and rollout

The bundled package does not contain the private projection contract required by the removed branch. The existing plugin copier continues to enforce path and symlink protections, honor cancellation, and clean up failed copies.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: 4b732db869

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: 4b732db869

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@zcrab-oai zcrab-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Removes an unreachable plugin projection branch while retaining safe tree copying, path checks, and cancellation.

@mldangelo-oai
mldangelo-oai merged commit b67ed88 into main Aug 14, 2026
55 of 58 checks passed
@mldangelo-oai
mldangelo-oai deleted the mdangelo/codex/remove-dead-plugin-projection branch August 14, 2026 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants