refactor(runtime): remove unused plugin projection path - #395
Conversation
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
zcrab-oai
left a comment
There was a problem hiding this comment.
Looks good. Removes an unreachable plugin projection branch while retaining safe tree copying, path checks, and cancellation.
Summary
Remove a bundled-plugin projection path that cannot run in the published package.
Changes
Testing
bun test tests-ts/runtime.test.ts --timeout 30000— 118 passed; 7 Windows-only tests skipped on macOS.pnpm run types— passed.prettier --check src/runtime.ts— passed.git diff --check— passed.Risk and rollout
The bundled package does not contain the private projection contract required by the removed branch. The existing plugin copier continues to enforce path and symlink protections, honor cancellation, and clean up failed copies.
Public disclosure review