Fixes #33023: evaluate neutral gray palette - #33150
Conversation
| | `tw:border-tertiary` | `--color-border-tertiary` | `#f5f5f5` (gray-100) | `#22262f` | Very subtle dividers | | ||
| | `tw:border-primary` | `--color-border-primary` | `#bfbfbf` (gray-300) | `#2e2e2e` (gray-700) | Default card, input, and divider borders | | ||
| | `tw:border-secondary` | `--color-border-secondary` | `#d9d9d9` (gray-200) | `#222222` (gray-800) | Subtle borders, section separators | | ||
| | `tw:border-secondary_alt` | `--color-border-secondary_alt` | `rgba(0,0,0,0.08)` | `#222222` | Alpha-transparent borders | |
There was a problem hiding this comment.
💡 Quality: Color handbook lists stale dark value for border-secondary_alt
This PR changes --color-border-secondary_alt in dark mode to rgb(255 255 255 / 0.08) (globals.css:1159, and called out in the PR summary as the intended 8% white-alpha edge), but the color handbook still documents its Dark value as the solid #222222. The handbook row was touched in this diff yet the Dark column wasn't updated, so it now contradicts the actual token and undermines the PR's claim that the handbook stays synchronized. Update the Dark cell to rgba(255,255,255,0.08).
Was this helpful? React with 👍 / 👎
| 200: '#D9D9D9', | ||
| 300: '#BFBFBF', | ||
| 400: '#A0A0A0', | ||
| 500: '#808080', |
There was a problem hiding this comment.
💡 Quality: Neutral gray-500 lowers muted/placeholder text contrast on white
gray-500 moves from #717680 (~4.6:1 on white) to #808080 (~3.9:1 on white). Tokens that map to gray-500 on light surfaces — text-quaternary, text-placeholder, text-disabled (colors.md:113-115) — now fall below the WCAG AA 4.5:1 threshold for normal text. Since this is a designer-driven palette experiment, confirm the muted/placeholder contrast is acceptable or nudge gray-500 slightly darker before this leaves draft.
Was this helpful? React with 👍 / 👎
Code Review 👍 Approved with suggestions 0 resolved / 2 findingsNeutral gray palette update aligns the shared color scale to proposed values with synchronized global tokens and handbook. Two minor items to address: the color handbook's Dark value for 💡 Quality: Color handbook lists stale dark value for border-secondary_alt📄 openmetadata-ui/src/main/resources/ui/docs/colors.md:170 📄 openmetadata-ui-core-components/src/main/resources/ui/src/styles/globals.css:1159 This PR changes 💡 Quality: Neutral gray-500 lowers muted/placeholder text contrast on white📄 openmetadata-ui-core-components/src/main/resources/ui/src/colors/defaultColors.ts:48 📄 openmetadata-ui/src/main/resources/ui/docs/colors.md:113-115 gray-500 moves from 🤖 Prompt for agentsOptionsDisplay: compact → Counting what did not apply, without listing it. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source |
Describe your changes:
Fixes #33023
Updates the shared gray primitives to the proposed neutral scale:
This PR intentionally contains only global palette and token changes. Home, AI Analytics, sidebar, card, icon, and interaction styling live in open-metadata/openmetadata-collate#6491 so OSS pages are not changed by this visual experiment.
Type of change:
High-level design:
Tests:
UI screen recording / screenshots:
Visual validation is covered by open-metadata/openmetadata-collate#6491 on:
/in light and dark mode/ai-dashboardsin light and dark modeChecklist: