Fixes #33023: evaluate neutral gray palette - #33024
Conversation
| --color-gray-200: var(--color-gray-200, #d9d9d9); | ||
| --color-gray-300: var(--color-gray-300, #bfbfbf); | ||
| --color-gray-400: var(--color-gray-400, #a0a0a0); | ||
| --color-gray-500: var(--color-gray-500, #808080); |
There was a problem hiding this comment.
⚠️ Edge Case: New gray-500 (#808080) fails WCAG AA for muted/placeholder text
The new gray-500 is #808080, which yields only ~3.95:1 contrast on a white background — below the WCAG 2.1 AA minimum of 4.5:1 for normal text. In light mode --color-text-quaternary, --color-text-placeholder, and --color-text-disabled all resolve to gray-500 (#808080), so placeholder, disabled, and muted body text become non-compliant (a regression from the old #717680 ≈ 4.6:1). The author already flags this in the PR body; before merge either lift these semantic tokens to a darker step (e.g. gray-600 #666666 ≈ 5.7:1) or darken gray-500 itself so the muted-text tokens clear 4.5:1.
Was this helpful? React with 👍 / 👎
| <Box | ||
| className={`tw:group tw:relative tw:cursor-pointer tw:rounded-xl tw:px-2 tw:py-3 tw:transition ${ | ||
| isActive ? 'tw:bg-utility-brand-50' : 'tw:hover:bg-utility-gray-blue-50' | ||
| isActive ? 'tw:bg-utility-brand-50' : 'hover:tw:bg-primary_hover' |
There was a problem hiding this comment.
⚠️ Bug: Tailwind prefix placed after variant breaks hover styles
In Tailwind v4 the configured prefix (tw:) must come first, before any variant. The new classes hover:tw:bg-primary_hover (ActivityFeedItem.tsx:196) and group-hover:tw:bg-secondary_hover (ActivityFeedItem.tsx:259) put the variant before the prefix, so Tailwind will not generate these utilities and the hover surfaces silently stop working. The replaced code used the correct order (tw:hover:bg-utility-gray-blue-50), and the rest of the repo consistently uses tw:hover: / tw:group-hover:. The new unit tests assert the literal wrong strings (toHaveClass('hover:tw:bg-primary_hover')), so they pass while masking the broken styling. Fix the class order to tw:hover:bg-primary_hover and tw:group-hover:bg-secondary_hover, and update the test expectations accordingly.
Was this helpful? React with 👍 / 👎
Code Review
|
| Compact |
|
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source
|
Superseded by #33150 after renaming the source branch. |
Describe your changes:
Fixes #33023
Updates the shared gray primitives to the proposed neutral scale:
This PR intentionally contains only global palette and token changes. Home, AI Analytics, sidebar, card, icon, and interaction styling live in open-metadata/openmetadata-collate#6491 so OSS pages are not changed by this visual experiment.
Type of change:
High-level design:
Tests:
UI screen recording / screenshots:
Visual validation is covered by open-metadata/openmetadata-collate#6491 on:
/in light and dark mode/ai-dashboardsin light and dark modeChecklist: