fix(cli): lower TEST_DEBT['@objectstack/rest'] to 155 and fix stale "Also in DEBT" note - #7248
Merged
Merged
Conversation
pnpm check:type-check-debt --re-measure showed the entry (163) sitting 12 above the actual tsc count (151 at dispatch time; 155 re-verified on this merge base, 55da611), a surplus that could absorb regressions silently since #6905 graduated the package's src half to a real compiler gate but left this TEST_DEBT entry as the sole guard on its test layer (#6939). The note also still read "Also in DEBT." after #6905 removed the package's DEBT entry -- a residual pointer to a ledger row that no longer exists (#7038). Rewrote it to "Graduated from DEBT in #6905." and updated the composition/bootstrap-margin prose so it describes the new exact-measurement state (no more +10 margin) instead of a stale reading of 163. --lower is not scoped to a single package, so it also touched 11 unrelated DEBT/TEST_DEBT entries across other packages; those were reverted to keep this PR to the @objectstack/rest entry only, per this card's scope. Fixes #6939 Fixes #7038 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0158ZQo7LiHSxGWpYKuPq1wu
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This was referenced Aug 10, 2026
os-help
marked this pull request as ready for review
August 10, 2026 04:19
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6939
Fixes #7038
What
scripts/check-type-check-coverage.mjs'sTEST_DEBT['@objectstack/rest']entry carried two problems, both surfaced during #6905 (the DEBT-ledger graduation of this package):@objectstack/rest的 DEBT 毕业后,TEST_DEBT 仍带 12 条余量 —— 且它现在是该包测试层唯一的看门人 #6939 — the recorded ceiling (163) sat 12 above the actual tsc count. 163 was itself a deliberate bootstrap margin (+10 over 153, per [finding] DEBT ledger counts in check-type-check-coverage.mjs drift silently — @objectstack/metadata-protocol records 28, actually reports 63 #5278 option A) meant to be tightened via theℹ … can be loweredhint right after landing, but it never was. Since@objectstack/rest已可零错编译,应从 #4311 的 DEBT 台账毕业 —— 加typecheck脚本 + 删台账条目(阻塞于 PR #6895) #6905 moved the package'ssrchalf to a realturbo run typecheckgate, this TEST_DEBT entry became the sole guard on the package's hidden test layer — the same "surplus absorbs a regression silently" shape [finding][devx]check:type-check-debt的 ledger 余量会让新写的 pin 变哑:mongodb 曾有 33 条余量吞掉一次真实回退,另有 5 条目前带 4–19 余量 #6376 documented fordriver-mongodb's 33-error margin, just smaller (12).TEST_DEBT['@objectstack/rest']的 note 仍写着 "Also in DEBT",但 #6905 已把 DEBT 条目删了 #7038 — the entry'snotestill read "Also in DEBT." after@objectstack/rest已可零错编译,应从 #4311 的 DEBT 台账毕业 —— 加typecheck脚本 + 删台账条目(阻塞于 PR #6895) #6905 removed the correspondingDEBTblock entry. That sentence became false the moment@objectstack/rest已可零错编译,应从 #4311 的 DEBT 台账毕业 —— 加typecheck脚本 + 删台账条目(阻塞于 PR #6895) #6905 landed, and it misleads the next person reading the note into looking for a DEBT row that no longer exists.What changed
errors: 163→errors: 155(the exactpnpm check:type-check-debt --re-measurecount on this PR's merge base,55da611). Re-measured with a fullturbo run buildclosure first, per the gate's own requirement.@objectstack/rest已可零错编译,应从 #4311 的 DEBT 台账毕业 —— 加typecheck脚本 + 删台账条目(阻塞于 PR #6895) #6905." (keeps the note's historical-reading style, per finding:TEST_DEBT['@objectstack/rest']的 note 仍写着 "Also in DEBT",但 #6905 已把 DEBT 条目删了 #7038's own suggested wording).@objectstack/rest的 DEBT 毕业后,TEST_DEBT 仍带 12 条余量 —— 且它现在是该包测试层唯一的看门人 #6939's re-measure found the true count (155), and the entry now equals the exact measurement with no margin — so the next new error there goes red immediately, matching what--lowerwrites for every entry it touches ([finding] DEBT ledger counts in check-type-check-coverage.mjs drift silently — @objectstack/metadata-protocol records 28, actually reports 63 #5278 composition-drift trap, closed).pnpm check:type-check-debt --loweritself is not scoped to a single package — running it also lowered 11 unrelatedDEBT/TEST_DEBTentries in other packages (@objectstack/metadata,service-automation,service-storage,plugin-approvals,objectql,runtime,plugin-auth,mcp,lint,plugin-security,http-conformance). Those are out of this card's scope, so they were reverted; only the@objectstack/restentry's numbers changed in the final diff.Out of scope (per dispatch): the sibling
tsconfig.test.jsonroute (#5286-style) that would let the test layer itself be typechecked and let this TEST_DEBT entry be deleted entirely. That is a ~151-file engineering effort, not a ledger-surplus fix, and #6939 explicitly calls it out as a separate, unstarted card.Tests / verification
Full workspace build closure first (required — the gate refuses to measure without it):
Self-test (independent of the real ledger — verified the fixtures at L2076-2099 are self-contained, per the dispatch's own assumption):
Full re-measure after the fix —
@objectstack/restno longer appears in theℹ … can be loweredlist (dropped from 12 flagged entries to 11, all unrelated to this package):node scripts/check-nul-bytes.mjs— clean.Tooling-script-only change (
scripts/check-type-check-coverage.mjs), no user-visible behavior — no changeset; requestingskip-changeset.Generated by Claude Code