Skip to content

Add edge case test for rate with zero payment #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Anurag42-git wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add edge case test for rate with zero payment #138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions numpy_financial/tests/test_financial.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,10 @@ class TestRate:
def test_rate(self):
assert_allclose(npf.rate(10, 0, -3500, 10000), 0.1107, rtol=1e-4)

def test_rate_zero_payment(self):
result = npf.rate(nper=10, pmt=0, pv=-1000, fv=1000)
assert np.isfinite(result)
Comment on lines +177 to +178

@Letme Letme Aug 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
result = npf.rate(nper=10, pmt=0, pv=-1000, fv=1000)
assert np.isfinite(result)
result = npf.rate(nper=10, pmt=0, pv=-1000, fv=1000)
assert np.isfinite(result)

Probably some more indent is needed (sorry for later review).


@pytest.mark.parametrize("number_type", [Decimal, float])
@pytest.mark.parametrize("when", [0, 1, "end", "begin"])
def test_rate_with_infeasible_solution(self, number_type, when):
Expand Down