Add edge case test for rate with zero payment - #138
Open
Anurag42-git wants to merge 1 commit into
Open
Conversation
Letme
suggested changes
Aug 26, 2026
Letme
left a comment
Letme
left a comment
There was a problem hiding this comment.
Nice to have an added test, but lets add some indentation so that it aligns with rest of the file.
Comment on lines
+177
to
+178
| result = npf.rate(nper=10, pmt=0, pv=-1000, fv=1000) | ||
| assert np.isfinite(result) |
There was a problem hiding this comment.
Suggested change
| result = npf.rate(nper=10, pmt=0, pv=-1000, fv=1000) | |
| assert np.isfinite(result) | |
| result = npf.rate(nper=10, pmt=0, pv=-1000, fv=1000) | |
| assert np.isfinite(result) |
Probably some more indent is needed (sorry for later review).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
-Adds an edge case test for the rate function when payment is zero
Why this change is needed:
-Improves test coverage and numerical stability checks in numpy-financial
Issue reference:
-Fixes #58