Repository navigation
fix(extension): open the panel with the defaults when a saved setting is not one it knows - #436
Merged
Merged
Conversation
Copy as Markdown treated every result with a rating as a metric, so an audit such as Script-Loading came out as a heading with "undefined" and none of its issues or items, and a result whose unit is a score threw before copying anything. The export picks its format with detectRenderer, as the page picks its view. detectRenderer moves to its own module so that the export can import it. A result the page shows as JSON is exported as JSON instead of "No issues found". The tests export the 114 result fixtures and fail on any "undefined" or "NaN".
… is not one it knows The panel looked for the radio of the saved theme and of the saved side, and with a value that has no radio, such as one synced from another version of the extension, the module threw and the panel stayed empty. The settings check each value they read: the theme, the side, the state of the list and the filter of the audit against the values the panel has, and the rest by type. A value that fails gives way to its default.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
4 of 5 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #435.
The panel looked for the radio of the saved theme and of the saved side of the list. With a value that has no radio, such as one synced from another version of the extension, the module threw and the panel stayed empty.
load()ofextension/lib/settings.jschecks each value it reads: the theme, the side, the state of the list and the filter of the audit against the values the panel has, and the rest by type.Test plan
npm run test:extensionlocally: 114 of 114.npm run test:extension:e2elocally: 94 of 94. The new case opens the realpanel.htmlin Chromium withtheme: "sepia"andside: "top"in a simulatedchrome.storage, and finds the list and the default options checked.npm run lintlocally.