Repository navigation
Conversation
A result with the unsupported status fell through to the metric row of the human and markdown reports, which printed "undefined" as its value and, in the markdown table, "· undefined" as its status. Both reports say "not supported" and the reason the snippet gives, or that the browser lacks the API when it gives none.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
5 tasks done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #436.
A result with the
unsupportedstatus fell through to the metric row of the human and markdown reports, which printedundefinedas its value and, in the markdown table,· undefinedas its status.not supportedand the reason the snippet gives, or that the browser lacks the API when it gives none.Test plan
· LCP undefinedin the human report and| LCP | undefined | · undefined |in the markdown one.npm run test:unit --prefix clilocally: 607 of 607.npm run lintlocally.largest-contentful-paintfromPerformanceObserver.supportedEntryTypes: the human report prints· LCP not supported: largest-contentful-paint entries not supported in this browser, the markdown one| LCP | · not supported | largest-contentful-paint entries not supported in this browser |, and--jsonkeeps"status":"unsupported". Through a pipe withNO_COLOR, the line is the same without color codes.