Skip to content

fix: keep idle validation on native timers#5397

Merged
mcollina merged 2 commits into
mainfrom
fix/main-ci-idle-validation
Jun 8, 2026
Merged

fix: keep idle validation on native timers#5397
mcollina merged 2 commits into
mainfrom
fix/main-ci-idle-validation

Conversation

@mcollina

@mcollina mcollina commented Jun 8, 2026

Copy link
Copy Markdown
Member

Summary

  • use native timers for idle socket validation so fake timers do not block background cache revalidation

Tests

  • node --test test/interceptors/cache.js
  • node --test test/response-queue-poisoning.js test/issue-810.js
  • npm run lint -- --quiet

Signed-off-by: Matteo Collina <hello@matteocollina.com>
@codecov-commenter

codecov-commenter commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.25%. Comparing base (04ebc71) to head (4ebf1ca).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5397      +/-   ##
==========================================
- Coverage   93.26%   93.25%   -0.02%     
==========================================
  Files         110      110              
  Lines       36757    36826      +69     
==========================================
+ Hits        34283    34341      +58     
- Misses       2474     2485      +11     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina mcollina merged commit c9fbe9d into main Jun 8, 2026
66 of 67 checks passed
@mcollina mcollina deleted the fix/main-ci-idle-validation branch June 8, 2026 16:57
mcollina added a commit that referenced this pull request Jun 8, 2026
* fix: keep idle validation on native timers

Signed-off-by: Matteo Collina <hello@matteocollina.com>

* test: wait for poisoned idle socket disconnect

Signed-off-by: Matteo Collina <hello@matteocollina.com>

---------

Signed-off-by: Matteo Collina <hello@matteocollina.com>
(cherry picked from commit c9fbe9d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants