Skip to content

fix: keep idle validation on native timers#5402

Merged
mcollina merged 1 commit into
v7.xfrom
backport/idle-validation-native-timers-v7
Jun 8, 2026
Merged

fix: keep idle validation on native timers#5402
mcollina merged 1 commit into
v7.xfrom
backport/idle-validation-native-timers-v7

Conversation

@mcollina

@mcollina mcollina commented Jun 8, 2026

Copy link
Copy Markdown
Member

Summary

Tests

  • node --test test/interceptors/cache.js test/response-queue-poisoning.js test/issue-810.js
  • npm run lint -- --quiet

* fix: keep idle validation on native timers

Signed-off-by: Matteo Collina <hello@matteocollina.com>

* test: wait for poisoned idle socket disconnect

Signed-off-by: Matteo Collina <hello@matteocollina.com>

---------

Signed-off-by: Matteo Collina <hello@matteocollina.com>
(cherry picked from commit c9fbe9d)
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.88%. Comparing base (b0ba52d) to head (99f3c7a).
⚠️ Report is 1 commits behind head on v7.x.

Additional details and impacted files
@@            Coverage Diff             @@
##             v7.x    #5402      +/-   ##
==========================================
- Coverage   92.89%   92.88%   -0.02%     
==========================================
  Files         112      112              
  Lines       35843    35912      +69     
==========================================
+ Hits        33298    33357      +59     
- Misses       2545     2555      +10     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollina mcollina merged commit 8e4046e into v7.x Jun 8, 2026
36 of 38 checks passed
@mcollina mcollina deleted the backport/idle-validation-native-timers-v7 branch June 8, 2026 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants