fix(links): open links on click and link bubble on hover - #9202
Merged
Merged
Conversation
github-project-automation
Bot
moved this to 馃Л Planning evaluation (don't pick)
in 馃摑 Productivity team
mejo-
moved this from 馃Л Planning evaluation (don't pick)
to 馃憖 In review
in 馃摑 Productivity team
mejo-
force-pushed
the
fix/open_link_on_click
branch
4 times, most recently
from
September 15, 2026 11:08
470760a to
4044c88
Compare
This was referenced Sep 15, 2026
marcoambrosini
approved these changes
Sep 16, 2026
marcoambrosini
left a comment
marcoambrosini
left a comment
Member
There was a problem hiding this comment.
very nice improvement!
max-nextcloud
approved these changes
Sep 22, 2026
max-nextcloud
left a comment
max-nextcloud
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me.
Some of the added playwright tests are failing - so that still needs to be fixed.
mejo-
force-pushed
the
fix/open_link_on_click
branch
from
September 22, 2026 16:03
48c21c0 to
7f0c1f6
Compare
* Open links straight away on click * On desktop open link bubble on hover * Add edit button to open link bubble after each link Fixes: nextcloud/collectives#1227 Fixes: nextcloud/collectives#2713 --- Also fixes a11y issue with keyboard navigation: with focussed link, the Enter key now opens the link. The link bubble can be opened by focussing the edit button behind the link and pressing Enter/Space. Fixes: #5528 Assisted-by: OpenCode:claude-fable-5 Signed-off-by: Jonas <jonas@freesources.org>
Fixes: #7600 Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: OpenCode:claude-fable-5
Fixes wrong bubble positioning in Collectives/Deck/etc. with Firefox. Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: OpenCode:claude-fable-5
Needed for a11y reasons now that it's impossible to navigate into the link text with the mouse (still possible with arrow keys). Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: OpenCode:claude-fable-5
Take the link bubble out of the flow before popper positions it, otherwise it briefly narrows the editor content and scroll anchoring scrolls the page. Fixes: #9110 Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: OpenCode:claude-fable-5
Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: OpenCode:claude-fable-5.1
mejo-
force-pushed
the
fix/open_link_on_click
branch
from
September 22, 2026 17:35
7f0c1f6 to
560410c
Compare
Member
Author
|
/backport to stable35 |
github-project-automation
Bot
moved this from 馃憖 In review
to 鈽戯笍 Done
in 馃摑 Productivity team
Member
Author
|
/backport to stable34 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
馃摑 Summary
Fixes: nextcloud/collectives#1227
Fixes: nextcloud/collectives#2713
Also fixes a11y issue with keyboard navigation: with focussed link, the Enter key now opens the link. The link bubble can be opened by, focussing the edit button behind the link and pressing Enter/Space.
Fixes: #5528
fix(linkBubble): focus href input field after Ctrl-K
Fixes: #7600
fix(LinkBubble): set tippy root position to absolute
Take the link bubble out of the flow before popper positions it, otherwise it briefly narrows the editor content and scroll anchoring scrolls the page.
Fixes: #9110
Assisted-by: OpenCode:claude-fable-5
Screenshots
馃弫 Checklist
npm run lint/npm run stylelint/composer run cs:check)馃 AI (if applicable)