[stable34] fix(links): open links on click and link bubble on hover - #9234
Merged
Merged
Conversation
backportbot
Bot
requested review from
marcoambrosini,
max-nextcloud and
mejo-
September 22, 2026 17:48
mejo-
force-pushed
the
backport/9202/stable34
branch
from
September 23, 2026 09:59
34d0ecc to
7c0f252
Compare
mejo-
marked this pull request as ready for review
September 23, 2026 09:59
* Open links straight away on click * On desktop open link bubble on hover * Add edit button to open link bubble after each link Fixes: nextcloud/collectives#1227 Fixes: nextcloud/collectives#2713 --- Also fixes a11y issue with keyboard navigation: with focussed link, the Enter key now opens the link. The link bubble can be opened by focussing the edit button behind the link and pressing Enter/Space. Fixes: #5528 Assisted-by: OpenCode:claude-fable-5 Signed-off-by: Jonas <jonas@freesources.org>
Fixes: #7600 Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: OpenCode:claude-fable-5
Fixes wrong bubble positioning in Collectives/Deck/etc. with Firefox. Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: OpenCode:claude-fable-5
Needed for a11y reasons now that it's impossible to navigate into the link text with the mouse (still possible with arrow keys). Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: OpenCode:claude-fable-5
Take the link bubble out of the flow before popper positions it, otherwise it briefly narrows the editor content and scroll anchoring scrolls the page. Fixes: #9110 Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: OpenCode:claude-fable-5
Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: OpenCode:claude-fable-5.1
Signed-off-by: Jonas <jonas@freesources.org>
mejo-
force-pushed
the
backport/9202/stable34
branch
from
September 23, 2026 10:58
7c0f252 to
5aa88e6
Compare
mejo-
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #9202
Warning, This backport's changes differ from the original and might be incomplete鈿狅笍
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.