feat: rebuild the Share Extension with SwiftUI

.github/workflows/xcode.yml

@@ -20,9 +20,9 @@ on:
 
 env:
   PROJECT: Nextcloud.xcodeproj
-  DESTINATION: platform=iOS Simulator,name=iPhone 17,OS=27.0
+  DESTINATION: platform=iOS Simulator,name=iPhone 17,OS=27.2
   SCHEME: Nextcloud
-  XCODE_VERSION: '27.1'
+  XCODE_VERSION: '27.2'
   SERVER_BRANCH: stable30
   PHP_VERSION: 8.3
 
@@ -60,7 +60,7 @@ jobs:
         retention-days: 4
 
   test:
-    name: Run Tests
+    name: Run Unit Tests
     runs-on: xcode-27
     timeout-minutes: 40
     needs: [build]
@@ -69,42 +69,6 @@ jobs:
 
     steps:
     - uses: actions/checkout@v7
-      with:
-        fetch-depth: 0
-
-    - name: Detect passcode changes
-      id: passcode_changes
-      shell: bash
-      env:
-        PR_BASE_SHA: ${{ github.event.pull_request.base.sha }}
-        PR_HEAD_SHA: ${{ github.event.pull_request.head.sha }}
-        PUSH_BEFORE_SHA: ${{ github.event.before }}
-      run: |
-        run_passcode_tests=false
-        if [ "$GITHUB_EVENT_NAME" = "pull_request" ]; then
-          compare_base=$(git merge-base "$PR_BASE_SHA" "$PR_HEAD_SHA")
-          compare_head="$PR_HEAD_SHA"
-        else
-          compare_base="$PUSH_BEFORE_SHA"
-          compare_head="$GITHUB_SHA"
-        fi
-
-        if [ -z "$compare_base" ] || [ "$compare_base" = "0000000000000000000000000000000000000000" ]; then
-          run_passcode_tests=true
-        else
-          git diff --name-only -z "$compare_base" "$compare_head" > "$RUNNER_TEMP/passcode-changed-files"
-          while IFS= read -r -d '' changed_file; do
-            case "$changed_file" in
-              iOSClient/Utility/Passcode/* | \
-              Tests/NextcloudUITests/PasscodeUITests.swift)
-                run_passcode_tests=true
-                break
-                ;;
-            esac
-          done < "$RUNNER_TEMP/passcode-changed-files"
-        fi
-        echo "run=$run_passcode_tests" >> "$GITHUB_OUTPUT"
-        echo "Run passcode UI tests: $run_passcode_tests"
 
     - name: Setup Xcode
       uses: maxim-lobanov/setup-xcode@ed7a3b1fda3918c0306d1b724322adc0b8cc0a90 # v1.7.0
@@ -166,33 +130,17 @@ jobs:
         xcrun simctl boot "iPhone 17"
         xcrun simctl bootstatus "iPhone 17" -b
 
-    - name: Check if Safari is installed
-      run: |
-        if xcrun simctl listapps booted | grep -q com.apple.mobilesafari; then
-          echo "Safari is installed in the simulator."
-        else
-          echo "Safari is NOT installed in the simulator."
-          exit 1
-        fi
-
-    - name: Run Xcode Test
+    - name: Run Xcode Unit Tests
       timeout-minutes: 25
       shell: bash
-      env:
-        RUN_PASSCODE_TESTS: ${{ steps.passcode_changes.outputs.run }}
       run: |
         set -o pipefail
-        test_selection=()
-        if [ "$RUN_PASSCODE_TESTS" != "true" ]; then
-          test_selection+=(-skip-testing:NextcloudUITests/PasscodeUITests)
-        fi
+        # UI tests remain available in the shared scheme for local execution.
         xcodebuild test-without-building \
         -xctestrun $(find . -type f -name "*.xctestrun") \
         -destination "${{ env.DESTINATION }}" \
         -derivedDataPath "DerivedData" \
-        "${test_selection[@]}" \
-        -test-iterations 3 \
-        -retry-tests-on-failure \
+        -only-testing:NextcloudUnitTests \
         -test-timeouts-enabled YES \
         -default-test-execution-time-allowance 600 \
         -maximum-test-execution-time-allowance 600 \

AGENTS.md

@@ -31,7 +31,10 @@ Other platforms like Android are irrelevant for this project.
 | `Brand` | Branding layer: `NCBrand.swift` (app constants, colors), `Database.swift` (Realm database name and schema version), Info.plists and entitlements for all targets, launch screen and intro screens. | Bump `databaseSchemaVersion` in `Brand/Database.swift` when changing Realm models. |
 | `File Provider Extension` | Contains business logic for the iOS File Provider extension. | — |
 | `File Provider Extension UI` | Contains UI logic for the iOS File Provider extension. | — |
-| `Share` | Contains code for the iOS Share extension. | — |
+| `Share` | Contains the active Share extension entry point, launched through `NSExtensionPrincipalClass`, plus input preparation, session storage and recent upload destinations. | — |
+| `Share/View` | Contains the SwiftUI Share extension interface. | Select the `Nextcloud` scheme for Xcode previews. Shared Share sources are hosted by the app only in Debug (`SHARE_PREVIEWS`) and excluded from app Release builds. |
+| `Share/Model` | Contains Share extension state, account handling and upload logic. | — |
+| `Share/UIKit` | Contains the previous UIKit Share extension sources and storyboard for reference. | Keep these reference files out of the Share target build. |
 | `Widget` | Contains code for iOS Widgets. | — |
 | `WidgetDashboardIntentHandler` | Contains the intent handler for the dashboard widget. | — |
 | `Notification Service Extension` | Contains the push notification service extension. | — |

BackgroundUploadExtension/NCBackgroundUploadExtensionManager.swift

@@ -393,6 +393,11 @@ final class NCBackgroundUploadExtensionManager {
     /// Disables the PhotoKit extension after the feature or auto upload is turned off and no jobs remain.
     /// Active metadata defers disabling so cancellations and terminal results can still be reconciled.
     func disableIfIdle() async -> Bool {
+        // Foreground cleanup must not trigger the initial Photos permission prompt.
+        guard PHPhotoLibrary.authorizationStatus(for: .readWrite) != .notDetermined else {
+            return false
+        }
+
         let featureEnabled = NCPreferences().shouldUseBackgroundUploadExtension
         let account = await database.getTableAccountAsync(predicate: NSPredicate(format: "autoUploadStart == true"))
 

Brand/Share.plist

@@ -25,17 +25,19 @@
 		<key>NSAllowsArbitraryLoads</key>
 		<true/>
 	</dict>
+	<key>NSFaceIDUsageDescription</key>
+	<string>Face ID is required to authenticate using face recognition.</string>
 	<key>NSExtension</key>
 	<dict>
 		<key>NSExtensionAttributes</key>
 		<dict>
 			<key>NSExtensionActivationRule</key>
 			<string>SUBQUERY (extensionItems, $extensionItem, SUBQUERY ($extensionItem.attachments, $attachment, (ANY $attachment.registeredTypeIdentifiers UTI-CONFORMS-TO "public.data" OR ANY $attachment.registeredTypeIdentifiers UTI-CONFORMS-TO "public.text")).@count == $extensionItem.attachments.@count).@count &gt; 0</string>
 		</dict>
-		<key>NSExtensionMainStoryboard</key>
-		<string>MainInterface</string>
+		<key>NSExtensionPrincipalClass</key>
+		<string>$(PRODUCT_MODULE_NAME).NCShareEntryController</string>
 		<key>NSExtensionPointIdentifier</key>
 		<string>com.apple.share-services</string>
 	</dict>
 </dict>
-</plist>
+</plist>