Skip to content

feat: rebuild the Share Extension with SwiftUI - #4430

Merged
marinofaggiana merged 51 commits into
masterfrom
share-review-ext
Nov 12, 2026
Merged

feat: rebuild the Share Extension with SwiftUI#4430
marinofaggiana merged 51 commits into
masterfrom
share-review-ext

Conversation

@marinofaggiana

@marinofaggiana marinofaggiana commented Oct 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Replaces the legacy Share Extension with a new SwiftUI interface and revised input preparation, account selection, and upload conflict handling.

  • Adaptive layout for portrait, landscape, iPad, and iPhone Duo.
  • Folder tree with favorites first and the last three upload destinations.
  • Account menu with avatars and aliases.
  • File thumbnails, renaming, removal, and upload count.
  • Revised item-provider loader with representation fallbacks, cancellation, and explicit import errors.
  • Dedicated conflict handling: replace or keep both for a single file, and unique copy names for multiple files.
  • Capabilities loaded from the database first, with a server fallback, plus offline feedback.

Adds unit tests for input loading, conflict naming, and recent destinations. Device testing and broader validation are still ongoing.

🤖 AI

  • The content of this PR was partly or fully generated using AI.

@marinofaggiana
refactor: migrate share extension to SwiftUI
b3fd03c 
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
fix: enable Share extension previews in the Nextcloud scheme
a5cc902 
Host Share sources in app Debug builds with SHARE_PREVIEWS and exclude them from Release builds. Gate preview code and document the required scheme.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
feat: add folder tree and recent destinations to Share extension
ebab7cd 
Persist the last three successful upload destinations per account and validate folders before selection. Add unit tests for recent destination storage.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
fix: load share extension capabilities and improve text import fallbacks
7395bbd 
Require server capabilities before browsing or uploading, with loading states and retry support. Fall back to usable text when other shared representations fail, including attributed text, and add import regression tests.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana marinofaggiana self-assigned this Oct 28, 2026
@marinofaggiana
marinofaggiana marked this pull request as draft October 28, 2026 17:23
@marinofaggiana marinofaggiana linked an issue Oct 28, 2026 that may be closed by this pull request
Review and modernize the Share Extension UI #4426
Closed
@marinofaggiana
Merge branch 'master' into share-review-ext
b18419b
@marinofaggiana
refactor: simplify share extension capability handling
5d5dc3c 
Centralize account readiness checks and pass capabilities explicitly through upload preparation and staging.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
fix: refine share extension folder selection and upload layout
94dd633 
Distinguish recent-folder selection from tree selection, streamline the folder and file lists, and show a pluralized file count on the upload button.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
fix: make cached share destinations usable during refresh
2b55388 
Refresh folders asynchronously and consolidate share status indicators into a single prioritized view.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
feat: improve share extension account menu and file previews
6ac18e1 
Replace the account picker sheet with a menu showing avatars and account aliases. Add cached Quick Look thumbnails with file-type icon fallbacks, and enlarge file and folder rows.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
fix: handle offline sharing and improve landscape layout
69c8c72 
Block network actions while offline and retry loading on reconnect. Adapt the Share extension to compact landscape layouts and show loading progress beside the account menu.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
fix: improve Share extension landscape layout
07039b3 
Place the folder header and upload button across both columns, let the file list fill available height, and round selected folder highlights.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
fix: open share file actions from the entire row
c136172 
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
fix: present share file actions in a confirmation dialog
2dab3b1 
Add an explicit cancel action and refine folder label colors and selection padding.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
feat: prioritize and badge favorite folders in Share extension
f5e30ac 
Show favorite folders first with accessible star badges, and scale file thumbnails to fill their frames.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana marinofaggiana changed the title Share review ext feat: rebuild the Share Extension with SwiftUI Oct 29, 2026
@marinofaggiana
fix: improve Share extension folder browsing and upload feedback
d201d5a 
Process only directories without replacing cached file metadata. Refine landscape layout, cap Dynamic Type scaling, and show conflict checks in the upload button.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
chore: remove Share folder timing logs and update launch path
8f1ae5b 
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
Merge branch 'master' into share-review-ext
f0b42aa
@marinofaggiana
chore: track NextcloudKit main branch
63aaf3d 
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
fix: improve share extension errors and destination readiness
665123d 
Show errors inline with retry or acknowledgment actions, and block uploads while the destination is loading or has failed.

Label recent and all folders, and use English (US) for previews and debug launches.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
refactor: remove legacy UIKit share extension
743fb90 
Delete obsolete UIKit sources and storyboard, remove their Xcode project references, and drop the unused animated GIF bridging import.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
chore: trim Share extension dependencies and update contributor docs
fdeebad 
Remove unused sources, resources, and package dependencies from the Share target. Refresh README guidance for SPDX headers, Xcode setup, and test servers.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
scheme
a9d2f4f 
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
Merge branch 'master' into share-review-ext
6027a10
@marinofaggiana
marinofaggiana marked this pull request as ready for review October 31, 2026 07:32
@marinofaggiana
fix: show cached share destinations before loading capabilities
938a660 
Initialize the folder browser before fetching server capabilities, then refresh folders once capabilities load. Show progress or errors while the share view initializes.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@mpivchev

mpivchev commented Nov 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  1. Choosing a folder results in loading always.

You can only do the network requests after pressing Upload?

  1. The toolbar title should not be changed. Use "Save to Nextcloud". There doesn't seem to be enough space so you can remove the name of the account from the tab bar. Only use avatar.

  2. Screenshot 2026-11-03 at 17 39 28

Icon is too small. Use the basic ... icon (without circle) to match other parts of the app.

  1. Remove the "No folders in here" item. It's not needed.

  2. Selecting a folder should automatically expand it, not only by pressing the arrow.

  3. Creating a folder should automatically select it and scroll to it.

  4. Sometimes pressing "Create folder" would close the whole share sheet. Not sure how to reproduce it yet. You can bug hunt with Claude.

@mpivchev

mpivchev commented Nov 3, 2026

Copy link
Copy Markdown
Collaborator
Screenshot 2026-11-03 at 17 58 18

This screen seems too complicated. No need for it IMO.

  1. For a single file, just add an alert saying if you want to "replace" "keep both" or "cancel"

  2. For multiple files, just keep both always if there is a conflict. No need to ask user to micromanage many files.

Dropbox does it like this and personally I'm a big fan. Really simple.

@kra-mo @jancborchardt @nimishavijay what do you think?

mpivchev
mpivchev requested changes Nov 4, 2026
View reviewed changes

@mpivchev mpivchev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check comments

@marinofaggiana
fix: improve Share extension browsing and filename display
f0a1ca2 
Preserve folder content during account switches and select and reveal newly created folders. Unify loading feedback, keep file extensions visible, and strip bidirectional controls from displayed filenames.

Tie folder dialog validation to the text field lifetime to avoid retaining alerts.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
Merge branch 'master' into share-review-ext
1bdd17a 
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
fix: cancel share operations when the selected account is removed
b5e2284 
Clear pending uploads and authentication state when no account is available, and suppress upload UI updates after cancellation.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
refactor: simplify share extension state management
874b3ff 
Derive account and folder readiness from existing state, keep upload data local, and silently remove unavailable recent folders.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
fix: ensure shared UTF-8 text uses a txt extension
c481e18 
Strengthen rich-text sharing coverage to verify the original RTF data is preserved.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
Merge branch 'master' into share-review-ext
eb78d87
@marinofaggiana
refactor: improve share upload conflict layout and actions
c2492fd 
Keep conflict actions visible below the file list, clarify button labels, and reuse a shared upload button.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
fix: left-align capability errors in share extension
fc78c2a 
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana

marinofaggiana commented Nov 9, 2026

Copy link
Copy Markdown
Member Author

@mpivchev pls review

@marinofaggiana
fix: improve Share extension passcode and biometric authentication
1f657b2 
Present the passcode within the Share panel and start biometrics after presentation completes. Add the Face ID usage description and resume authentication after upload confirmation is dismissed.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
refactor: simplify Share extension state and upload flow
bbf0302 
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
Merge branch 'master' into share-review-ext
df6e70e
@marinofaggiana
test: use AppConfig login for passcode UI tests
be7be74 
Provision passcode test accounts from launch environment credentials in debug builds, while keeping browser authentication as the default for other UI tests.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
ci: extend Xcode test timeouts and remove explicit test iterations
d88e168 
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
ci: validate app password login before passcode tests
b06590d 
Increase the test job timeout to 60 minutes and the Xcode test timeout to 45 minutes.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
Merge branch 'master' into share-review-ext
207a9d9
@marinofaggiana
fix: avoid Photos permission prompt during background upload cleanup
b1f50dc 
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
test: allow 90 seconds for AppConfig login in CI
6f99bc7 
Run the presented-sheet passcode test once to validate the timeout.

Assisted-by: Codex:gpt-6
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
ci: use Xcode 27.2 and iOS 27.2 simulator
b44bf19 
Assisted-by: Codex:gpt-6
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
ci: restore bounded Xcode test timeouts
67dfaaa
@marinofaggiana
ci: run only unit tests in GitHub Actions
6928107
@marinofaggiana
Merge branch 'master' into share-review-ext
eef15d8
@marinofaggiana
Merge branch 'master' into share-review-ext
9b4197c
@marinofaggiana
chore: bump marketing version to 35.3.0
1e5b033 
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
marinofaggiana merged commit 2f9f0ef into master Nov 12, 2026
5 checks passed
@marinofaggiana
marinofaggiana deleted the share-review-ext branch November 12, 2026 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpivchev mpivchev Awaiting requested review from mpivchev mpivchev is a code owner

Assignees

@marinofaggiana marinofaggiana

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Review and modernize the Share Extension UI

2 participants

@marinofaggiana @mpivchev