Repository navigation
fix(submission): use the same answer checks for validating and storing - #3916
Merged
Merged
Conversation
Validating an answer and storing it each had their own checks for the option ids of a question and for the answer "Other". Both now use the same helpers: the answer "Other" is recognized in one place, and option ids are read by one function, which takes a number or a string of its digits, as the API documentation now says. The message for an answer to a question that is not part of the form names the id as it was sent. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Member
Author
|
/backport! to stable5.4 |
1 task done
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Chartman123
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #3833, so it can be merged and backported on its own. The commit is unchanged and drops out of #3833 once this is merged.
Tests
SubmissionServiceTestfor ids sent in other notations, with and without the answer "Other".🤖 AI (if applicable)