Skip to content

fix(submission): use the same answer checks for validating and storing - #3916

Merged
Chartman123 merged 1 commit into
mainfrom
fix/submission-answer-checks
Nov 18, 2026
Merged

Chartman123 merged 1 commit into
mainfrom
fix/submission-answer-checks

Conversation

@AndyScherzinger

Copy link
Copy Markdown
Member

Split out of #3833, so it can be merged and backported on its own. The commit is unchanged and drops out of #3833 once this is merged.

  • Validating an answer and storing it each had their own checks for the option ids of a question and for the answer "Other". Both now use the same helpers, so an answer is read the same way in both steps.
  • Option ids are read by one function, which takes a number or a string of exactly its digits. The API documentation says so now.
  • The message for an answer to a question that is not part of the form names the id as it was sent.

Tests

  • New cases in SubmissionServiceTest for ids sent in other notations, with and without the answer "Other".

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI (N/A)

Validating an answer and storing it each had their own checks for the
option ids of a question and for the answer "Other". Both now use the
same helpers: the answer "Other" is recognized in one place, and option
ids are read by one function, which takes a number or a string of its
digits, as the API documentation now says. The message for an answer to
a question that is not part of the form names the id as it was sent.

Assisted-by: Claude Code:claude-opus-5-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger added this to the 5.5 milestone Nov 18, 2026
@AndyScherzinger AndyScherzinger added bug Something isn't working 3. to review Waiting for reviews AI assisted labels Nov 18, 2026
@AndyScherzinger AndyScherzinger self-assigned this Nov 18, 2026
@AndyScherzinger

Copy link
Copy Markdown
Member Author

/backport! to stable5.4

@backportbot backportbot Bot added the backport-request Pending backport by the backport-bot label Nov 18, 2026
@backportbot backportbot Bot removed the backport-request Pending backport by the backport-bot label Nov 18, 2026
@codecov

codecov Bot commented Nov 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Chartman123
Chartman123 merged commit 52e5396 into main Nov 18, 2026
51 checks passed
@Chartman123
Chartman123 deleted the fix/submission-answer-checks branch November 18, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews AI assisted bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants