Skip to content

[stable5.4] fix(submission): use the same answer checks for validating and storing - #3921

Merged
Chartman123 merged 1 commit into
stable5.4from
backport/3916/stable5.4
Nov 18, 2026
Merged

Chartman123 merged 1 commit into
stable5.4from
backport/3916/stable5.4

Conversation

@backportbot

@backportbot backportbot Bot commented Nov 18, 2026

Copy link
Copy Markdown

Backport of PR #3916

Validating an answer and storing it each had their own checks for the
option ids of a question and for the answer "Other". Both now use the
same helpers: the answer "Other" is recognized in one place, and option
ids are read by one function, which takes a number or a string of its
digits, as the API documentation now says. The message for an answer to
a question that is not part of the form names the id as it was sent.

Assisted-by: Claude Code:claude-opus-5-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@backportbot backportbot Bot added bug Something isn't working 3. to review Waiting for reviews AI assisted labels Nov 18, 2026
@codecov

codecov Bot commented Nov 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@AndyScherzinger AndyScherzinger added this to the 5.4.3 milestone Nov 18, 2026
@Chartman123
Chartman123 merged commit ae32449 into stable5.4 Nov 18, 2026
51 checks passed
@Chartman123
Chartman123 deleted the backport/3916/stable5.4 branch November 18, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews AI assisted bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants