Skip to content

fix(api): do not return deleted questions - #3908

Merged
Chartman123 merged 1 commit into
mainfrom
fix/api-deleted-question
Nov 17, 2026
Merged

Chartman123 merged 1 commit into
mainfrom
fix/api-deleted-question

Conversation

@AndyScherzinger

Copy link
Copy Markdown
Member

Split out of #3833, so it can be merged and backported on its own. The commit is unchanged and drops out of #3833 once this is merged.

  • Requesting a single question returned a question the owner had deleted, with its text and options, while the list of questions leaves it out. A deleted question now gets a Not Found response, like a question that does not exist. The API docs say so.

Tests

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Requesting a single question also returned a question the owner had
deleted, with its text and options, to everyone who can open the form,
while the list of questions leaves it out. A deleted question now gets
a Not Found response, like a question that does not exist.

Assisted-by: Claude Code:claude-opus-5-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger added this to the 5.5 milestone Nov 17, 2026
@AndyScherzinger AndyScherzinger added bug Something isn't working 3. to review Waiting for reviews AI assisted labels Nov 17, 2026
@AndyScherzinger AndyScherzinger self-assigned this Nov 17, 2026
@AndyScherzinger

Copy link
Copy Markdown
Member Author

/backport to stable5.4

@backportbot backportbot Bot added the backport-request Pending backport by the backport-bot label Nov 17, 2026
@codecov

codecov Bot commented Nov 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Chartman123
Chartman123 merged commit a4c31bf into main Nov 17, 2026
51 checks passed
@Chartman123
Chartman123 deleted the fix/api-deleted-question branch November 17, 2026 23:24
@backportbot backportbot Bot removed the backport-request Pending backport by the backport-bot label Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews AI assisted bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants