Repository navigation
fix(api): do not change deleted questions - #3910
Merged
Merged
Conversation
Changing a question the owner had deleted, or its options, still worked: its text and settings could be updated, and options added, changed, deleted and reordered, although the question no longer shows anywhere. These requests now get a Not Found response, like a question that does not exist, as reading, copying, reordering and deleting a deleted question already do. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Member
Author
|
/backport to stable5.4 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Chartman123
approved these changes
Nov 18, 2026
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3908. Changing a question the owner had deleted, or its options, still worked through the API, although the question no longer shows anywhere. Like reading, copying, reordering and deleting a deleted question already do, these requests now get a Not Found response:
PATCH /forms/{id}/questions/{questionId}(update a question)POST /forms/{id}/questions/{questionId}/options(add options)PATCH /forms/{id}/questions/{questionId}/options/{optionId}(update an option)DELETE /forms/{id}/questions/{questionId}/options/{optionId}(delete an option)PATCH /forms/{id}/questions/{questionId}/options(reorder options)Only users who can edit the form could reach these requests; nothing is restored and respondents are not affected. The docblocks already listed the 404, so
openapi.jsonis unchanged.Tests
ApiControllerTestfor the five endpoints. PHPUnit: 5 more tests thanmain, no new failures.🤖 AI (if applicable)