Repository navigation
Report queues that have no live worker - #21
Merged
Merged
Conversation
The dashboard alert can ask the manager which queues are unworked, using the same heartbeat rule as before.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Manager::isProcessed()answers whether a live worker is registered for a queue, using the same heartbeat rule as the dashboard alert.Manager::unworkedQueues()is that list for discovered queues, and the dashboard alert now asks the manager instead of scanning workers itself.Test plan
QUEUE_WORKER_HEARTBEAT_STALEclears that queue from the alert.isProcessed()is true for an undiscovered queue only when a live worker lists that class.