Skip to content

Let find-replace searches use a chosen queue - #1

Merged
hellopablo merged 2 commits into
developfrom
feat/configurable-find-replace-queue
Oct 21, 2026
Merged

hellopablo merged 2 commits into
developfrom
feat/configurable-find-replace-queue

Conversation

@hellopablo

@hellopablo hellopablo commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

Summary

  • FIND_REPLACE_QUEUE chooses the queue for admin and API searches. When it is unset, searches use default.
  • An unknown queue is rejected before a search is saved or a rerun clears its results.
  • The Find & Replace index warns when Manager::isProcessed() reports that the queue has no live worker. That is the same check as the queue dashboard alert in Report queues that have no live worker module-queue#21.
  • Search list column widths live in the module admin CSS at 250px, instead of inline 200px styles on the table headers.

Test plan

  • With FIND_REPLACE_QUEUE set to priority, a new search is pushed onto priority.
  • With no live worker for that queue, the index shows the warning and the search stays pending.
  • With an unknown queue name, the index says the queue is not available and the search is not saved.
  • ./vendor/bin/phpunit tests/Service/QueueTest.php passes once this package is installed with the module-queue release that includes isProcessed().
  • On the Find & Replace index, Status, Progress, Results, Last run, and Actions are 250px, and the Term column takes the remaining width.

Searches were always pushed onto the default queue, and the index gave no sign when that queue had no worker.
The 200px widths were inline on the search table and too narrow for the status and action columns.
@hellopablo
hellopablo marked this pull request as draft October 21, 2026 19:37
@hellopablo
hellopablo marked this pull request as ready for review October 21, 2026 19:38
@hellopablo
hellopablo merged commit 744e212 into develop Oct 21, 2026
5 checks passed
@hellopablo
hellopablo deleted the feat/configurable-find-replace-queue branch October 21, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant