Skip to content

Drop the bottom margin when a table ends a fieldset #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hellopablo merged 1 commit into from
Oct 21, 2026
Merged

Drop the bottom margin when a table ends a fieldset #287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets/css/admin.ui.min.css
View file
Open in desktop

Large diffs are not rendered by default.

12 changes: 12 additions & 0 deletions assets/sass/admin-ui/objects/_table.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,18 @@ fieldset > :last-child:not(legend) > .table-rounded {
}
}

// `.table` carries a bottom margin so it separates from whatever follows.
// The card's border stops that margin collapsing out, so a table that ends
// the fieldset leaves an empty strip inside the card. A trailing element
// hidden by jQuery `.toggle()` still counts as ending the card — same case
// the fieldset radius rules treat as last.
fieldset > table:last-child,
fieldset > :last-child:not(legend) > table:last-child,
fieldset > table:nth-last-child(2):has(+ [hidden], + [style*="display: none"]),
fieldset > :nth-last-child(2):has(+ [hidden], + [style*="display: none"]) > table:last-child {
margin-bottom: 0;
}

// Opt-in sticky header. `.table-responsive` on the same element sets
// overflow-x which would kill `position: sticky`, so restore visible overflow.
.table-sticky {
Expand Down
Loading