Skip to content

Drop the bottom margin when a table ends a fieldset - #287

Merged
hellopablo merged 1 commit into
developfrom
fix/fieldset-table-margin
Oct 21, 2026
Merged

hellopablo merged 1 commit into
developfrom
fix/fieldset-table-margin

Conversation

@hellopablo

Copy link
Copy Markdown
Member

Summary

  • A table that is the last thing in a fieldset no longer keeps Bootstrap's 1rem bottom margin. The card border was trapping that margin as an empty strip along the bottom.
  • The same rule covers a table wrapped in one element, and a table followed only by a sibling hidden with jQuery .toggle().

Test plan

  • Open an admin page whose fieldset ends in a plain table (Find & Replace → My searches) and confirm the last row sits on the card's bottom border.
  • Confirm a .table-rounded table inside a fieldset is unchanged.
  • Confirm a table that is not the last element in a fieldset still has space beneath it.

The card border traps Bootstrap's table margin as an empty strip.
@hellopablo
hellopablo enabled auto-merge October 21, 2026 18:10
@hellopablo
hellopablo merged commit e6b3b2d into develop Oct 21, 2026
5 checks passed
@hellopablo
hellopablo deleted the fix/fieldset-table-margin branch October 21, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant