Repository navigation
docs: add README visuals from the example app; fix its landscape grid - #31
Merged
Merged
Conversation
- README gains a 'See it in action' section: a GIF of the example app widening from one to three columns, and iPhone 16 Simulator screenshots in portrait and landscape. Images live in assets/readme/ (not shipped in the npm package) and use absolute raw URLs so they render on npmjs.com too. - Example app: running it in the iOS Simulator showed only one card per row in landscape, because the computed card width ignored the landscape safe-area insets. Cards now use a percentage width with flexGrow, so the column count fits the space actually available.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
README visuals. A new "See it in action" section with:
xstolgtoxxl), recorded from the web buildxs, one column) and landscape (lg, two columns)The images live in
assets/readme/, which isn't in the npm package. The README uses absoluteraw.githubusercontent.comURLs so they also render on npmjs.com.Example app fix found in the iOS Simulator. In landscape only one card fit per row, because the card width was calculated from the full window and ignored the safe-area insets beside the Dynamic Island. Cards now use a percentage
widthwithflexGrow, which fits the real available space. I checked it again in the Simulator: two columns in landscape, clear of the Dynamic Island.Removes the em dash from the example's card text.
Test plan
npm pack --dry-rundoesn't includeassets/