Skip to content

fix(motion-gpu): export reactive texture option types #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alectimison-maker wants to merge 1 commit into
base: master
Choose a base branch
from
+21 −2
Open

fix(motion-gpu): export reactive texture option types #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/motion-gpu/src/lib/svelte/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ export type {
UsePointerOptions,
UsePointerResult
} from './use-pointer.js';
export type { TextureUrlInput, UseTextureResult } from './use-texture.js';
export type { TextureOptionsInput, TextureUrlInput, UseTextureResult } from './use-texture.js';
export type {
StorageBufferAccess,
StorageBufferDefinition,
Expand Down
2 changes: 1 addition & 1 deletion packages/motion-gpu/src/lib/vue/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ export type {
UsePointerOptions,
UsePointerResult
} from './use-pointer.js';
export type { TextureUrlInput, UseTextureResult } from './use-texture.js';
export type { TextureOptionsInput, TextureUrlInput, UseTextureResult } from './use-texture.js';
export type {
StorageBufferAccess,
StorageBufferDefinition,
Expand Down
19 changes: 19 additions & 0 deletions packages/motion-gpu/src/tests/public-api.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,20 @@ import * as react from '../lib/react/index';
import * as reactAdvanced from '../lib/react/advanced';
import * as svelte from '../lib/svelte/index';
import * as svelteAdvanced from '../lib/svelte/advanced';
import type { TextureOptionsInput as SvelteTextureOptionsInput } from '../lib/svelte/index';
import * as vue from '../lib/vue/index';
import * as vueAdvanced from '../lib/vue/advanced';
import type { TextureOptionsInput as VueTextureOptionsInput } from '../lib/vue/index';

const packageRoot = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..', '..');

function acceptReactiveTextureOptions(
svelteOptions: SvelteTextureOptionsInput,
vueOptions: VueTextureOptionsInput
): [SvelteTextureOptionsInput, VueTextureOptionsInput] {
return [svelteOptions, vueOptions];
}

function readPackageJson(): {
exports: Record<string, { types: string; default: string; svelte?: string }>;
} {
Expand All @@ -34,6 +43,16 @@ function sourceEntryForDistPath(distPath: string): string {
}

describe('public api contract', () => {
it('exports reactive adapter texture option input types', () => {
expect(acceptReactiveTextureOptions({}, {})).toEqual([{}, {}]);
expect(
acceptReactiveTextureOptions(
() => ({}),
() => ({})
)
).toHaveLength(2);
});

it('exports framework-agnostic runtime symbols from root and /core entrypoints', () => {
expect(Object.keys(api).sort()).toEqual([
'BlitPass',
Expand Down