fix(motion-gpu): export reactive texture option types - #13
Open
alectimison-maker wants to merge 1 commit into
Open
fix(motion-gpu): export reactive texture option types#13alectimison-maker wants to merge 1 commit into
alectimison-maker wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TextureOptionsInputfrom the Svelte and Vue adapter entrypointsMotivation
useTexture()already accepts an options object or lazy options provider and its adapter modules export the correspondingTextureOptionsInputtype. The package export map exposes only the adapter barrels, however, and those barrels omitted the type. Consumers therefore could not name the public input type without importing a non-exported internal path.Design
This reuses the existing type and adds type-only barrel exports. The regression test imports through the same public adapter barrels consumers use and compiles both the object and lazy-provider forms. Existing runtime export snapshots remain unchanged.
Testing
pnpm exec tsc --noEmit --project tsconfig.json— passedpnpm exec vitest run src/tests/public-api.test.ts— 7 tests passedpnpm run test— 60 files and 808 tests passedpnpm exec svelte-check --tsconfig ./tsconfig.json— passed with 0 errors and 0 warningspnpm exec vue-tsc --project tsconfig.vue.json --noEmit— passedUnavailable on this Windows checkout:
pnpm run buildreaches declaration generation, thenscripts/build/emit-vue-dts.mjscannot directly spawn the extensionless POSIXnode_modules/.bin/vue-tscshim (ENOENT)Compatibility and risks
The change is additive and type-only. It does not add runtime exports, alter texture loading behavior, or change the React adapter.
Scope
No runtime or build-script changes are included.