Apply focused CMake build cleanup#1462
Merged
Merged
Conversation
Split the broad code-cleanup PR into a smaller CMake-only review slice. Preserve the existing core SDK C++ standard behavior while removing unsafe fast-math flags, normalizing CMake status output, aligning package version metadata, and keeping zlib definitions compatible with older CMake. Files changed: CMakeLists.txt, lib/CMakeLists.txt, tests/*/CMakeLists.txt, tools/Make*.cmake, tools/ParseOsRelease.cmake, zlib/CMakeLists.txt Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Jun 5, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens up the project’s CMake build configuration and packaging metadata, keeping changes focused on build hygiene and version alignment.
Changes:
- Removes
-ffast-math(and its related release-flag pairing) from release build flags to avoid unsafe floating-point optimizations. - Normalizes CMake logging and compatibility patterns (e.g.,
message(STATUS ...), quotingif(EXISTS ...),configure_file(... COPYONLY)for cross-version file copies). - Aligns CPack-driven package version metadata (DEB/RPM/TGZ) with the current 3.10 API version, without raising the required C++ standard.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
CMakeLists.txt |
Removes unsafe release flags, updates API version to 3.10, and standardizes configure-time status output. |
lib/CMakeLists.txt |
CMake hygiene updates (quoted EXISTS, STATUS messages, and correct message(FATAL_ERROR ...) syntax). |
tests/unittests/CMakeLists.txt |
Makes module/test source discovery more robust via quoting and consistent top-level source/binary dir variables. |
tests/functests/CMakeLists.txt |
Same as unittests: improves module discovery paths, file copy compatibility, and logging consistency. |
tools/ParseOsRelease.cmake |
Quotes EXISTS path and uses message(STATUS ...) for cleaner CMake output. |
tools/MakeDeb.cmake |
Updates package minor version to 10 and standardizes packaging output logging. |
tools/MakeRpm.cmake |
Updates package minor version to 10 and standardizes packaging output logging. |
tools/MakeTgz.cmake |
Updates package minor version to 10 and standardizes packaging output logging. |
zlib/CMakeLists.txt |
Adjusts Windows compile definitions handling within the zlib sub-build. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
baijumeswani
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is split out of #1416 to keep the review surface small and focused.
Changes:
-ffast-mathusage from CMake release flags.Validation performed locally:
git diff --checkCMAKE_POLICY_VERSION_MINIMUM=3.5