Apply CMake best practices and remove stale references by bmehta001 · Pull Request #1416 · microsoft/cpp_client_telemetry

bmehta001 · 2026-03-18T08:34:30Z

Pure build/project cleanup

CMake improvements (3 files)

Cleanup / CMake hygiene

add LANGUAGES C CXX to the top-level project() call
switch build/config logging to message(STATUS ...) instead of bare message(...)
Fix message(FATAL_ERROR, ...) comma bug (invalid CMake syntax)
fix if(EXISTS ...) quoting in lib/, tests/functests/, and tests/unittests
simplify cross-version file copies to configure_file(... COPYONLY)
remove stale Visual Studio project/header references
update VS toolset fallback logic in Solutions/before.targets and Solutions/build.MIP.props
Update MATSDK_API_VERSION from 3.4 to 3.10 to match recent releases
Remove empty compiler-id blocks (Clang/Intel/MSVC with no content); GCC -fPIC flags preserved
Remove commented-out bondlite test block and stale TODO comments
Remove duplicate include_directories entry

Visual Studio project cleanup (8 files)

Remove stale header references that no longer exist in the repo:
- targetver.h (SampleCpp, SampleCppMini)
- LogManagerV1.hpp (Shared.vcxitems)
- MockILocalStorageReader.hpp (UnitTests.vcxproj)
- SanitizerBaseTests.cpp (FuncTests.vcxproj)
Modernize VS toolset fallback logic instead of relying on the old hardcoded v141 defaults.

Packaging

keep the package install-dir overrides that Debian/RPM packaging expects
adjust packaging messages / cleanup so the CMake changes stay behavior-correct

lalitb

see comments.

Copilot

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.

Derive package version components from MATSDK_BUILD_VERSION so CPack packages stay aligned with the SDK version. Use PROJECT_SOURCE_DIR and PROJECT_BINARY_DIR for test CMake paths so the SDK remains subproject-friendly. Files changed: - CMakeLists.txt - tools/MakeDeb.cmake - tools/MakeRpm.cmake - tools/MakeTgz.cmake - tests/functests/CMakeLists.txt - tests/unittests/CMakeLists.txt Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 4 comments.

Validate MATSDK_BUILD_VERSION before deriving CPack version components and remove now-dead DAYNUMBER calculations from package scripts. Files changed: - CMakeLists.txt - tools/MakeDeb.cmake - tools/MakeRpm.cmake - tools/MakeTgz.cmake Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated no new comments.

# Conflicts: # lib/CMakeLists.txt

Copilot

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.

The previous merge from main left a conflict marker block in lib/CMakeLists.txt's trailing commented-link section. Remove the marker block and keep the cleaned-up file content. Files changed: - lib/CMakeLists.txt Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated no new comments.

Keep package script version cleanup out of the CMake cleanup PR; package version alignment can be handled separately before the next release. Files changed: - CMakeLists.txt - tools/MakeDeb.cmake - tools/MakeRpm.cmake - tools/MakeTgz.cmake Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Add an explicit VS2026/v145 command-line build entry alongside the existing VS2022/v143 script so Windows consumers can choose the right supported toolset without guessing from MSBuild internals. Files changed: - docs/cpp-start-windows.md - build-all-v145.bat - tools/vcvars.cmd - Solutions/before.targets Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

This reverts commit b99ff14.

bmehta001 · 2026-05-30T17:49:02Z

Sorry, pushed a commit to this branch by accident, so have reverted it.

zlib/CMakeLists.txt still targets old CMake compatibility, but add_compile_definitions requires newer CMake. Restore add_definitions for the Windows preprocessor definitions so the zlib subproject remains compatible with the branch's stated CMake floor. Validation: - cmake configure with CMAKE_POLICY_VERSION_MINIMUM=3.5 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 21 out of 21 changed files in this pull request and generated no new comments.

bmehta001 · 2026-06-05T15:50:10Z

Also had requested Baiju/Manaswi to take a look, but this PR is quite large and has a long history, so splitting it into #1462. #1463, and #1464 for easier review and closing this one

bmehta001 requested a review from a team as a code owner March 18, 2026 08:34

bmehta001 force-pushed the bhamehta/code-cleanup branch 2 times, most recently from 34e4948 to 790fdd0 Compare March 18, 2026 09:03

bmehta001 changed the title ~~Use best CMake practices, rm outdated headers, and update VS settings~~ Use best CMake practices, rm/update outdated code Mar 18, 2026

bmehta001 force-pushed the bhamehta/code-cleanup branch 18 times, most recently from 9a5a166 to 2feeb94 Compare March 19, 2026 05:40

bmehta001 self-assigned this Mar 19, 2026

lalitb reviewed Mar 21, 2026

View reviewed changes

Comment thread lib/CMakeLists.txt Outdated

lalitb reviewed Mar 21, 2026

View reviewed changes

Comment thread lib/CMakeLists.txt Outdated

lalitb reviewed Mar 21, 2026

View reviewed changes

Comment thread lib/CMakeLists.txt Outdated

lalitb reviewed Mar 21, 2026

View reviewed changes

Comment thread lib/CMakeLists.txt Outdated

lalitb reviewed Mar 21, 2026

View reviewed changes

Comment thread lib/CMakeLists.txt Outdated

lalitb requested changes Mar 21, 2026

View reviewed changes

ThomsonTan reviewed Mar 21, 2026

View reviewed changes

Comment thread lib/http/HttpClient_Apple.mm Outdated

bmehta001 requested a review from Copilot May 28, 2026 21:17

Copilot started reviewing on behalf of bmehta001 May 28, 2026 21:17 View session

Copilot AI reviewed May 28, 2026

View reviewed changes

Comment thread CMakeLists.txt

Comment thread tests/functests/CMakeLists.txt Outdated

Comment thread tests/unittests/CMakeLists.txt

bmehta001 and others added 2 commits May 29, 2026 11:42

Merge branch 'main' into bhamehta/code-cleanup

d2e2bd1

bmehta001 requested a review from Copilot May 29, 2026 20:40

Copilot started reviewing on behalf of bmehta001 May 29, 2026 20:41 View session

Copilot AI reviewed May 29, 2026

View reviewed changes

Comment thread CMakeLists.txt Outdated

Comment thread tools/MakeDeb.cmake

Comment thread tools/MakeRpm.cmake

Comment thread tools/MakeTgz.cmake

bmehta001 requested a review from Copilot May 29, 2026 20:52

Copilot started reviewing on behalf of bmehta001 May 29, 2026 20:52 View session

Copilot AI reviewed May 29, 2026

View reviewed changes

Merge remote-tracking branch 'msft/main' into bhamehta/code-cleanup

248d53f

# Conflicts: # lib/CMakeLists.txt

Copilot AI reviewed May 29, 2026

View reviewed changes

Comment thread lib/CMakeLists.txt Outdated

Copilot AI reviewed May 29, 2026

View reviewed changes

bmehta001 and others added 3 commits May 29, 2026 17:28

Revert "Document current Visual Studio build toolsets"

b721bc5

This reverts commit b99ff14.

bmehta001 and others added 3 commits June 2, 2026 00:17

Merge branch 'main' into bhamehta/code-cleanup

a17a337

Merge branch 'main' into bhamehta/code-cleanup

47a4cbd

Copilot AI reviewed Jun 3, 2026

View reviewed changes

Merge branch 'main' into bhamehta/code-cleanup

6d97f5c

baijumeswani approved these changes Jun 4, 2026

View reviewed changes

This was referenced Jun 5, 2026

Apply focused CMake build cleanup #1462

Merged

Remove stale MSBuild references #1463

Merged

Make Curl CA path ownership safe #1464

Open

Conversation

bmehta001 commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CMake improvements (3 files)

Visual Studio project cleanup (8 files)

Packaging

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lalitb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

bmehta001 commented May 30, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

bmehta001 commented Jun 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

bmehta001 commented Mar 18, 2026 •

edited

Loading