Skip to content

Fall back to inotify when fanotify rejects mounts with EXDEV #65325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jake Bailey (jakebailey) merged 2 commits into from
Nov 6, 2026
Merged

Fall back to inotify when fanotify rejects mounts with EXDEV #65325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
351d9a6
Fall back to inotify when fanotify rejects mounts with EXDEV
jakebailey Nov 4, 2026
702b175
Remove redundant fanotify fallback comment
jakebailey Nov 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tsc/internal/fswatch/fanotify_linux.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ func (b *fanotifyBackend) markDir(w *dirWatch, path string, markPath string) err
}

func maybeWrapUnsupportedFilesystem(err error) error {
if errors.Is(err, unix.EOPNOTSUPP) || errors.Is(err, unix.ENOTSUP) || errors.Is(err, unix.ENODEV) {
if errors.Is(err, unix.EOPNOTSUPP) || errors.Is(err, unix.ENOTSUP) || errors.Is(err, unix.ENODEV) || errors.Is(err, unix.EXDEV) {
return fmt.Errorf("%w: %w", err, ErrFilesystemUnsupported)
}
return err
Expand Down
16 changes: 9 additions & 7 deletions tsc/internal/fswatch/fanotify_linux_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,13 +127,15 @@ func TestLinuxFanotifyMaybeWrapUnsupportedFilesystem(t *testing.T) {
// Errnos that indicate the filesystem cannot support fanotify FID-based
// watching are tagged with ErrFilesystemUnsupported so higher layers can
// fall back to inotify (issue #63646).
for _, errno := range []error{unix.EOPNOTSUPP, unix.ENODEV} {
wrapped := maybeWrapUnsupportedFilesystem(fmt.Errorf("name_to_handle_at: %w", errno))
if !errors.Is(wrapped, ErrFilesystemUnsupported) {
t.Errorf("expected %v to be tagged ErrFilesystemUnsupported", errno)
}
if !errors.Is(wrapped, errno) {
t.Errorf("expected wrapped error to still unwrap to %v", errno)
for _, errno := range []error{unix.EOPNOTSUPP, unix.ENODEV, unix.EXDEV} {
for _, err := range []error{errno, fmt.Errorf("name_to_handle_at: %w", errno)} {
wrapped := maybeWrapUnsupportedFilesystem(err)
if !errors.Is(wrapped, ErrFilesystemUnsupported) {
t.Errorf("expected %v to be tagged ErrFilesystemUnsupported", err)
}
if !errors.Is(wrapped, errno) {
t.Errorf("expected wrapped error to still unwrap to %v", errno)
}
}
}

Expand Down
Loading