Repository navigation
Fall back to inotify when fanotify rejects mounts with EXDEV - #65325
Merged
Jake Bailey (jakebailey) merged 2 commits intoNov 6, 2026
Merged
Conversation
Fanotify FID groups can reject watches spanning incompatible mounts with EXDEV, including virtiofs mounts. Treating this as fatal prevents watch mode from receiving any file changes despite inotify being usable. Fixes 65290.
Jake Bailey (jakebailey)
requested review from
Andrew Branch (andrewbranch) and
John Favret (johnfav03)
and
a balanced review from Copilot
November 4, 2026 20:16
typescript-automation
Bot
added
For Uncommitted Bug
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the change enabling inotify fallback when fanotify returns EXDEV.
No open issues 🎉
What changed in this PR
Addresses #65290 by allowing Linux file watching to fall back to inotify when fanotify rejects a mount with EXDEV, rather than leaving watch mode unable to detect changes.
Changes:
- Classifies
EXDEVas an unsupported-filesystem error. - Expands tests to cover raw and wrapped errors, checking both fallback classification and preservation of the original error.
| File | Description |
|---|---|
tsc/internal/fswatch/fanotify_linux.go |
Tags EXDEV with ErrFilesystemUnsupported to enable fallback. |
tsc/internal/fswatch/fanotify_linux_test.go |
Adds EXDEV coverage and tests raw and wrapped error inputs. |
Review effort: Balanced
Jake Bailey (jakebailey)
enabled auto-merge
November 5, 2026 18:41
John Favret (johnfav03)
approved these changes
Nov 6, 2026
Member
Author
|
TypeScript Bot (@typescript-bot) cherry-pick this to release-7.0 |
Contributor
Contributor
|
Hey, Jake Bailey (@jakebailey)! I've created #65369 for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #65290