-
Notifications
You must be signed in to change notification settings - Fork 67
[MOO - 2286] : Release script fixes to automate Docs and Changelog PR in NT- 19-x-x #1273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
saurabhchavan1711
wants to merge
17
commits into
release/19.x.x
Choose a base branch
from
moo/MOO-2286-docs-pr-automation-19-x-x
base: release/19.x.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+110
−57
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
9983a6c
remove sync file removal changes from release docs script
saurabhchavan1711 7e4df9d
add sync step and create directory if missing
saurabhchavan1711 01f74f4
testing commit for folder creation
saurabhchavan1711 9cc4e88
revert folder creation testing commit
saurabhchavan1711 a9cbbda
merge publishing flow with release flow
saurabhchavan1711 7b7bcc5
delete publish changelog yaml file and update release list
saurabhchavan1711 0fe6ea6
Add sync logic to run every day
saurabhchavan1711 b220839
Revert "delete publish changelog yaml file and update release list"
saurabhchavan1711 9d4dce5
Add logic to raise PR in NT to update changelog
saurabhchavan1711 6f29502
Fix base branch for changelog in NT
saurabhchavan1711 594be38
Use force to push to NT branch
saurabhchavan1711 1f0cc86
Delete Publishing changelog job and update release list
saurabhchavan1711 f2271f9
Improvements in release script and pipeline file
saurabhchavan1711 94b134a
remove the sync job as it will be on master
saurabhchavan1711 9ea060d
add publish job for testing new pAT
saurabhchavan1711 306b8c6
remove publish changelog to docs yml file
saurabhchavan1711 2e9a24b
Merge branch 'release/19.x.x' into moo/MOO-2286-docs-pr-automation-19…
saurabhchavan1711 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With error-handling in mind, I'm thinking what would happen in the scenario of
updateNTReleaseNotesfailing. From what it looks like now:createPRUpdateChangelog()might throw ("A pull request already exists for..."), causing the entire script to fail on retry without ever reaching the docs step.Maybe we can look into handling at least this error if it gets thrown whenever we call the pulls.create API. Ideally we can consider making the operation idempotent by editing the existing PR.