[MOO - 2286] : Release script fixes to automate Docs and Changelog PR in NT- 19-x-x - #1273
Open
saurabhchavan1711 wants to merge 17 commits into
Open
[MOO - 2286] : Release script fixes to automate Docs and Changelog PR in NT- 19-x-x#1273saurabhchavan1711 wants to merge 17 commits into
saurabhchavan1711 wants to merge 17 commits into
Conversation
This reverts commit f8f8f72.
MxKevinBeqo
reviewed
Jul 28, 2026
| await updateNTChangelog(changelog, unreleasedContent, changelogPath); | ||
|
|
||
| // Update release notes in docs repo | ||
| await updateNTReleaseNotes(unreleasedContent); |
Contributor
There was a problem hiding this comment.
With error-handling in mind, I'm thinking what would happen in the scenario of updateNTReleaseNotes failing. From what it looks like now:
- A draft PR in native-template is created with no corresponding docs PR.
- On re-run,
createPRUpdateChangelog()might throw ("A pull request already exists for..."), causing the entire script to fail on retry without ever reaching the docs step.
Maybe we can look into handling at least this error if it gets thrown whenever we call the pulls.create API. Ideally we can consider making the operation idempotent by editing the existing PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR
Checklist
To ensure this pull request meets the requirements for merging, please complete the checklist below:
This PR contains