Repository navigation
Preserve scratch artifacts after runner and hook failures - #66
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--keep-tmpdir=failurenow preserves diagnostics after hook failures, aborted runs, invalid runner settings, and report-writing errors, including runner failures handled by the caller. Successful runs still clean up;neverandalwayskeep their explicit policies.AG;DR
BASHTEST_TMPDIRor the caller'sTEST_TMPDIR.sh_test; each report-write case uses a fresh destination so it verifies a real write error. Document the retention policy and Bazel sandbox boundary.Validation on published head
438c9e5eb653521225d41258edd1a6db8655dd3d: focused pre-commit (all 73 Python tests),bazel test //...,bazel test --enable_runfiles=no //..., and external consumer integration. Local validation uses macOS Bash 3.2; Windows-only runtime coverage is incompatible locally. All checks passed in CI run 40217094526, including Linux, macOS, and managed Windows integration.Dependencies: PR #65 is merged and its main run 40216264168 passed every check. No open PR dependencies. This is the scratch-retention part of the sequential diagnostics work; golden diffs, call sites, live output, and interruption diagnostics remain for later focused PRs after this one merges. Catchable signals retain artifacts; SIGKILL and Bazel sandbox removal remain outside the runner's cleanup control.