Repository navigation
Show assertion source locations and golden diffs by default - #67
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failed expectations now identify their source file and line, and golden-file failures show the unified diff without requiring
--verbose. Both diagnostics appear in captured stderr and JUnit reports, so CI can explain a failure directly.AG;DR
ERRtrap metadata can identify the function declaration instead of the failing command. Those diagnostics retain command/status without claiming an inaccurate source line.<result>.diffartifact and golden-update behavior. Verbose mode prints the failure diff once; its previous diff stdout now consistently uses stderr with other failure diagnostics.Validation on published head
279e5580c36d4ecdc638266857d176f48e418ea6: focused pre-commit (all 76 Python tests),bazel test //...,bazel test --enable_runfiles=no //..., and external consumer integration. Local tests use macOS Bash 3.2; the Windows-only runtime target is incompatible locally. All checks passed in CI run 40220320804, including Linux, macOS, and managed Windows integration.Dependencies: PR #66 is merged and main CI run 40217519049 passed every check. No open PR dependencies. This is the assertion-location/golden-diff part of the diagnostics plan; live output capture and interruption diagnostics follow after this PR merges.