fix(maintenance): own SCL trial client lifetime - #420
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit finding M-01: unowned read-only trial association
At the exact
mainbaseb897203fad3b9276492bd3f6220e6c86d14c59df,SclSafeTrialRunner.RunAsynccreated aNativeIec61850Clientand captured a diagnostic, then exited its try/catch without disposing that client. The native client implementsIAsyncDisposableand owns a network association and gates. This read-only, explicit CLI trial route is separate from the live monitoring path.Fix
Use an
await usingdeclaration in the owning trial scope. The client remains alive throughConnectUsingSclAsyncandCaptureDiagnosticSnapshot, then is asynchronously released on success, cancellation or failure. Add a deterministic source-contract test to prevent accidental reintroduction of the unowned client. The test does not claim real-device or network validation.Invariants / scope
Services/SclSafeTrialRunner.csandtests/ARSAS.Tests/SclSafeTrialRunnerTests.cs.