Repository navigation
fix(deps-merge): ignore superseded cancelled checks - #198
Merged
Merged
Conversation
…mergeable again The first scheduled deps-merge runs refused marola-ml#90, a green pip-only minor bump, twice. On 2026-10-19 it said "checks not green (CANCELLED)": the PR workflow started 3 times when Dependabot opened the PR, concurrency cancelled 2, and the rollup still lists them after the newest run passed. On 2026-10-20 it said "not mergeable (UNKNOWN)": GitHub computes mergeable only when asked, and a read a few seconds later says MERGEABLE. judge drops a CANCELLED check only when a newer run of the same check (workflow and name; the higher job id in detailsUrl, then startedAt) exists. An older FAILURE still counts, so a newer run that skips its jobs cannot hide it. settle reads an UNKNOWN mergeable again, up to five times 3 seconds apart, before the PR is refused. Both apply in both modes. The fixture gets #90's real rollup and diff (#415, now merged) and an older FAILURE behind a newer pass (#416, refused); a stub gh tests the re-read. The tools reference row names both rules. Part of marola-dev/marola#740 Tested: gates — deps-merge.sh --self-test ok (the 5 new #415/#416 checks and the 2 re-read checks fail before the fix); every quality line in bash (ruff, shellcheck, actionlint, tests/self-tests.sh, wiring --lint-devkit, agents-check, merge_key_check, docs_lint, skills_vendor, release --check, claude plugin validate): all ok; a read-only --unattended --dry-run on marola-ml makes #90 READY, pinned to 25a884f Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WpCVVuPjnM15cpFrytsKY8
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary — The first scheduled deps-merge runs refused marola-ml#90, a green pip-only minor bump, twice. On 2026-10-19 it said "checks not green (CANCELLED)": the PR workflow started 3 times when Dependabot opened the PR, concurrency cancelled 2, and the rollup still lists them after the newest run passed.
What changed
5b93451)