Repository navigation
fix(routing): route impact follows references edges - #196
Merged
Merged
Conversation
graphify 0.9.74 keeps one edge per node pair. When a method both names a type and constructs it, the edge it keeps is often `references` (the type use) rather than `calls`, so `route impact Coordinates` lost Main.scala and SwimConditionsMcpServer.scala and the umbrella's bench dropped impact 5 -> 4 on the nixpkgs bump in marola-dev/marola#897. Walking `references` too restores 5/5 on 0.9.74 and leaves 0.9.53's answers unchanged. Tested: tests/route_test.py (new test_impact_follows_references, red first); umbrella routing-bench.yaml on main's pins: 0.9.74 20/34 -> 21/34, 0.9.53 21/34 -> 21/34; just quality all ok except format.sh's scalafmt self-test, which fails the same on clean main (host scalafmt) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary — graphify 0.9.74 keeps one edge per node pair. When a method both names a type and constructs it, the edge it keeps is often
references(the type use) rather thancalls, soroute impact Coordinateslost Main.scala and SwimConditionsMcpServer.scala and the umbrella's bench dropped impact 5 -> 4 on the nixpkgs bump in marola-dev/marola#897.Tested:trailer (AGENTS.md)What changed
cdfbc03)