Repository navigation
Design: Caps Lock rules on every keyboard (with spike evidence) - #1336
Merged
Merged
Conversation
Proposes mapping Caps Lock on every compatible keyboard (one device-scoped mapping each, hot-plug aware, journaled per device) instead of requiring a chosen keyboard. Records the lab-mini spike: several keyboards mapped and restored independently, per-device attribution without seizing, merge behaviour with existing mappings, and the open questions (existing Caps remaps, multi-interface boards, hot-plug timing, a stuck F18 under load). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposes replacing the "choose a keyboard for Caps Lock" requirement with a per-device Caps mapping on every compatible keyboard, and records the spike that tested it on the lab mini.
Doc:
docs/architecture/all-keyboards-caps.mdWhy
Managed Caps tracks exactly one device (
SessionCapsSelection, a one-device lease journal,automaticSelectionrequiringdevices.count == 1). Any Mac with an external keyboard, and every multi-interface board, therefore needs a manual choice. On the lab mini (cl80, X2A, ESP32 fixture) Caps Lock rules have been paused at every session start.Spike results (mini, master
112c0b1fc)Open questions for review
Docs only. No code changes.
Review gate: the local
Scripts/review-gate.shcould not run (Claude CLI OAuth session expired on this machine, exit 1 "review did not complete"). Relying on GitHubclaude-review; do not merge until it passes.🤖 Generated with Claude Code