Skip to content

feat: add clipped video tab component#972

Closed
vij-sameerb5 wants to merge 1 commit into
magicuidesign:mainfrom
vij-sameerb5:clipped-video-tab
Closed

feat: add clipped video tab component#972
vij-sameerb5 wants to merge 1 commit into
magicuidesign:mainfrom
vij-sameerb5:clipped-video-tab

Conversation

@vij-sameerb5

Copy link
Copy Markdown

Description

Adds a cinematic clipped video tab component with responsive full-width layout, floating content cards, and immersive media presentation.

Changes

  • Added clipped-video-tab component
  • Added demo preview component
  • Added component documentation page
  • Registered component and example in Magic UI registry
  • Added responsive full-width media support

Motivation

Provide a modern cinematic UI section for hero layouts, feature showcases, and immersive landing page experiences.

Breaking Changes

None

Screenshots

Screenshot 2026-05-25 at 12 04 15 AM

Device / Browser / Viewport:
MacBook Pro / Chrome / 1512×982

| Before | After |

Screenshot 2026-05-25 at 12 05 12 AM

| --- | --- |
| N/A | Added cinematic clipped video tab component |

@vercel

vercel Bot commented May 24, 2026

Copy link
Copy Markdown

@vij-sameerb5 is attempting to deploy a commit to the product-studio Team on Vercel.

A member of the Team first needs to authorize it.

@Yeom-JinHo Yeom-JinHo self-requested a review May 25, 2026 14:37
@Yeom-JinHo

Copy link
Copy Markdown
Member

Thanks for the contribution! Closing this for now — it would need substantial rework to meet the library bar:

  1. Sidebar not registered. apps/www/config/docs.ts is missing an entry for clipped-video-tab, so the doc page is unreachable from the nav.
  2. Dependency convention break. The repo standard is "motion", but this uses "framer-motion". It also adds framer-motion to the root package.json instead of apps/www/package.json (which already has motion).
  3. Scope creep. Changes to tweet-card.tsx, public/r/tweet-card.json, and the tweet-card section of llms-full.txt are unrelated to this component — please split them into a separate PR.
  4. No dark mode. Hardcoded bg-white, text-[#131313], #266347, etc. Should use design tokens (bg-background, text-foreground, …).
  5. No props API. items is a module-level constant — users can't customize anything without forking the component.
  6. Hot-linked media. All four videos are served from a personal Cloudinary account; if it goes away, every consumer's demo breaks.
  7. <AnimatePresence> around <motion.video> unmounts/remounts the video on every tab switch — heavy re-download and a black flash. Cross-fade with opacity on persistent <video> elements instead.
  8. Content mismatches. The "Audio Transcription" tab has a JWT-auth goal, and the footer hardcodes 2/5 tasks complete / Est. 45s remaining across all tabs.

Happy to re-review once these are addressed in a fresh PR.

@Yeom-JinHo Yeom-JinHo closed this May 27, 2026
@vij-sameerb5

Copy link
Copy Markdown
Author

thanks to valuable insights i will be back with updating these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants