Skip to content

feat: add clipped video tab component#974

Closed
vij-sameerb5 wants to merge 1 commit into
magicuidesign:mainfrom
vij-sameerb5:clipped-video-tab
Closed

feat: add clipped video tab component#974
vij-sameerb5 wants to merge 1 commit into
magicuidesign:mainfrom
vij-sameerb5:clipped-video-tab

Conversation

@vij-sameerb5

Copy link
Copy Markdown

Description

This PR adds a new cinematic clipped-video-tab component with animated tab transitions, clipped fullscreen video layouts, and responsive behavior for modern landing pages.

This update also addresses previous review feedback related to registry integration, theming consistency, component structure, and performance improvements.

Changes

  • Added clipped-video-tab component
  • Added demo preview component
  • Added documentation page
  • Added sidebar navigation entry
  • Added registry integration
  • Added responsive layout support
  • Replaced hardcoded colors with theme tokens
  • Refactored component structure for reusable props
  • Improved video transition performance
  • Removed unrelated file changes from the PR

Motivation

This component was built to provide a reusable cinematic media section for AI/SaaS style landing pages with immersive visuals and modern interactions while aligning with MagicUI architecture and contribution standards.

Breaking Changes

None.

Screenshots

Device / Browser / Viewport:

Before After
Previous version had hardcoded styles and missing registry integration Added fully integrated cinematic clipped video tab component with responsive behavior and improved performance

@Yeom-JinHo Yeom-JinHo self-requested a review June 1, 2026 03:59
@Yeom-JinHo

Copy link
Copy Markdown
Member

@vij-sameerb5
Identical commit to #972 (edba87c) — none of the 8 review points were addressed. Closing. please reopen once they're actually fixed.

@Yeom-JinHo Yeom-JinHo closed this Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants