Skip to content

chore: bump org.jetbrains.kotlin:kotlin-stdlib-common in /kits/adobemedia/adobemedia-3 #967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dependabot wants to merge 1 commit into from
Closed

chore: bump org.jetbrains.kotlin:kotlin-stdlib-common in /kits/adobemedia/adobemedia-3 #967

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kits/adobemedia/adobemedia-3/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
buildscript {
ext.kotlin_version = '2.1.20'
ext.kotlin_version = '2.1.21'

@claude claude Bot Oct 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 (optional) This kit ends up on a mixed Kotlin toolchain, and the Kotlin version it publishes no longer matches the other kits in the shared kits build. The kit is still included in settings-kits.gradle:10, so the root build.gradle classpath supplies kotlin-gradle-plugin 2.1.20 and that parent-loaded plugin wins. The kit's configurations.all block (force plus eachDependency) still rewrites every org.jetbrains.kotlin:kotlin-* dependency to 2.1.21. Fix: leave kotlin_version at '2.1.20' to match the root and the other in-build kits. Alternatively, bump the root and every in-build kit together, or move the kit to a standalone build.

Why this was flagged

The kits build runs with -c settings-kits.gradle and includes ':kits:adobemedia:adobemedia-3' (settings-kits.gradle:10). Its root project is ./build.gradle, which puts kotlin-gradle-plugin 2.1.20 on the root buildscript classpath (build.gradle:2,12). Subproject buildscript classloaders delegate to the parent first, so the classpath entry at line 16 of this file, kotlin-gradle-plugin:$kotlin_version (now 2.1.21), does not change which plugin runs. The configurations.all resolutionStrategy in this file still forces kotlin-stdlib, -jdk7, -jdk8 and -common to 2.1.21. The result is a 2.1.20 plugin driving 2.1.21 artifacts. The published POM also requires kotlin-stdlib 2.1.21, while core and every other in-build kit use 2.1.20. On the base branch the whole kits build used 2.1.20 consistently. AGENTS.md says a kit that needs a different Kotlin version is commented out of settings-kits.gradle and built standalone.

Verification: Trigger: every kits build, i.e. any -c settings-kits.gradle run. settings-kits.gradle:10 still includes ':kits:adobemedia:adobemedia-3'. Root build.gradle:2 sets ext.kotlin_version = '2.1.20' and build.gradle:12 puts kotlin-gradle-plugin:$kotlin_version on the root buildscript classpath. So the plugin bump is half-applied: plugin 2.1.20 drives a 2.1.21 compiler/stdlib.

if (!project.hasProperty('version') || project.version.equals('unspecified')) {
project.version = '+'
}
Expand Down
Loading