Repository navigation
chore: bump org.jetbrains.kotlin:kotlin-stdlib-common in /kits/adobemedia/adobemedia-3 - #967
Conversation
Bumps [org.jetbrains.kotlin:kotlin-stdlib-common](https://github.com/JetBrains/kotlin) in `/kits/adobemedia/adobemedia-3` from 2.1.20 to 2.1.21. Updates `org.jetbrains.kotlin:kotlin-stdlib-common` from 2.1.20 to 2.1.21 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md) - [Commits](JetBrains/kotlin@v2.1.20...v2.1.21) --- updated-dependencies: - dependency-name: org.jetbrains.kotlin:kotlin-stdlib-common dependency-version: 2.1.21 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: gradle ... Signed-off-by: dependabot[bot] <support@github.com>
Kotlin migration progressNo change to the Java left to convert.
Conversion progress: 0.0% (16,728 of 16,550 baseline Java LOC left to convert). 132 Java files and 36 Kotlin files in scope. |
Binary compatibility
Compares the release AAR against the same artifact at the last version published to Maven Central; R8-renamed classes and members are excluded (see the script docstring). Full japicmp HTML/XML reports are attached as the |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| @@ -1,5 +1,5 @@ | |||
| buildscript { | |||
| ext.kotlin_version = '2.1.20' | |||
| ext.kotlin_version = '2.1.21' | |||
There was a problem hiding this comment.
🟡 (optional) This kit ends up on a mixed Kotlin toolchain, and the Kotlin version it publishes no longer matches the other kits in the shared kits build. The kit is still included in settings-kits.gradle:10, so the root build.gradle classpath supplies kotlin-gradle-plugin 2.1.20 and that parent-loaded plugin wins. The kit's configurations.all block (force plus eachDependency) still rewrites every org.jetbrains.kotlin:kotlin-* dependency to 2.1.21. Fix: leave kotlin_version at '2.1.20' to match the root and the other in-build kits. Alternatively, bump the root and every in-build kit together, or move the kit to a standalone build.
Why this was flagged
The kits build runs with -c settings-kits.gradle and includes ':kits:adobemedia:adobemedia-3' (settings-kits.gradle:10). Its root project is ./build.gradle, which puts kotlin-gradle-plugin 2.1.20 on the root buildscript classpath (build.gradle:2,12). Subproject buildscript classloaders delegate to the parent first, so the classpath entry at line 16 of this file, kotlin-gradle-plugin:$kotlin_version (now 2.1.21), does not change which plugin runs. The configurations.all resolutionStrategy in this file still forces kotlin-stdlib, -jdk7, -jdk8 and -common to 2.1.21. The result is a 2.1.20 plugin driving 2.1.21 artifacts. The published POM also requires kotlin-stdlib 2.1.21, while core and every other in-build kit use 2.1.20. On the base branch the whole kits build used 2.1.20 consistently. AGENTS.md says a kit that needs a different Kotlin version is commented out of settings-kits.gradle and built standalone.
Verification: Trigger: every kits build, i.e. any -c settings-kits.gradle run. settings-kits.gradle:10 still includes ':kits:adobemedia:adobemedia-3'. Root build.gradle:2 sets ext.kotlin_version = '2.1.20' and build.gradle:12 puts kotlin-gradle-plugin:$kotlin_version on the root buildscript classpath. So the plugin bump is half-applied: plugin 2.1.20 drives a 2.1.21 compiler/stdlib.
📦 SDK Size Impact ReportWhat the SDK adds to a minified release APK. mParticle Core SDKMeasured against an empty baseline app. Unlike the Rokt kit, android-core ships no Compose and no resources, so there is nothing here that a host app would already provide.
mParticle Core + Rokt kitMeasured against a Compose + Material3 reference app, so these are the costs on top of an app that already ships Compose. The reference app's dependencies are a documented convention, not a measured average: see
Rokt SDK+ umbrella (adds the payment extension)
➡️ SDK size impact change is minimal. Raw measurementscore, Target branch: {"baseline_dex_bytes": 0, "baseline_download_bytes": 2510, "baseline_install_bytes": 7527, "core_dex_bytes": 220412, "core_download_bytes": 123805, "core_install_bytes": 131055}core, This PR: {"baseline_dex_bytes": 0, "baseline_download_bytes": 2514, "baseline_install_bytes": 7531, "core_dex_bytes": 220412, "core_download_bytes": 123804, "core_install_bytes": 131054}rokt, Target branch: {"baseline_dex_bytes": 1829108, "baseline_download_bytes": 1240062, "baseline_install_bytes": 1300934, "kit_dex_bytes": 4170020, "kit_download_bytes": 2548125, "kit_install_bytes": 2623275, "sdkplus_dex_bytes": 9291568, "sdkplus_download_bytes": 7985699, "sdkplus_install_bytes": 8165359}rokt, This PR: {"baseline_dex_bytes": 1829108, "baseline_download_bytes": 1240062, "baseline_install_bytes": 1300934, "kit_dex_bytes": 4170020, "kit_download_bytes": 2548127, "kit_install_bytes": 2623275, "sdkplus_dex_bytes": 9291568, "sdkplus_download_bytes": 7985701, "sdkplus_install_bytes": 8165359} |
Bumps org.jetbrains.kotlin:kotlin-stdlib-common in
/kits/adobemedia/adobemedia-3from 2.1.20 to 2.1.21.Updates
org.jetbrains.kotlin:kotlin-stdlib-commonfrom 2.1.20 to 2.1.21Release notes
Sourced from org.jetbrains.kotlin:kotlin-stdlib-common's releases.
... (truncated)
Changelog
Sourced from org.jetbrains.kotlin:kotlin-stdlib-common's changelog.
... (truncated)
Commits
f59375aAdd ChangeLog for 2.1.21-RC2301186f[Gradle] Fix passing process environment when launching KotlinKarma tests12b4021Add changelog for 2.1.21-RCe16f5a8[IC] Update inline function snapshotting5f12d8b[Cherry-picks] Update BTA specific parts for the release branchf025799[IC] Additional test cases for inline function snapshotting58df05e[Tests] More tests for inline fun abi snapshotting9512893[KGP] Experimental: support incremental changes in inlined local classes950cee5[IC] Additional test cases for inlined lambda snapshottinga0a8ca0[BTA Tests] Fix changedSources tracking when compilation fail is expectedDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions