Skip to content

fix: guard null sidebar pointer in setAlive close path #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pengfeixx wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −1
Open

fix: guard null sidebar pointer in setAlive close path #396

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion reader/uiframe/DocSheet.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1797,7 +1797,9 @@ void DocSheet::setAlive(bool alive)
if (m_documentChanged && m_renderer) {
if (m_renderer->save()) {
m_documentChanged = false;
m_sidebar->changeResetModelData();
if (m_sidebar) {
m_sidebar->changeResetModelData();
}
// 注释保存后文件内容已变化，重写书签刷新内容指纹，
// 避免下次打开时书签因指纹不匹配被误判为旧文件遗留
Database::instance()->saveBookmarks(filePath(), m_bookmarks);
Expand Down
Loading